[webrtc] Attempt to fix SDP answers for strict browsers (WIP)#496
Closed
rorygallagher2024 wants to merge 3 commits intopython-ring-doorbell:masterfrom
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:\n- Attempt to correct Ring SDP answers to be compatible with stricter WebRTC implementations.\n\nContext:\n- This branch includes SDP-related fixes and a small device-kind addition for PTZ indoor cameras so Pan‑Tilt models are recognized.\n- Related earlier PR: https://github.com/python-ring-doorbell/python-ring-doorbell/pull/491\n\nHow to test:\n- Vendor this branch into Home Assistant at
config/custom_components/ringor pip-install the branch into a running HA container and verify the integration picks up the branch.\n\nNotes:\n- This is a WIP change. Please test in real Home Assistant setups and paste negotiation logs if issues persist.