WebRTC Answer Fix for Firefox and Device Addition#491
Merged
tchellomello merged 9 commits intopython-ring-doorbell:masterfrom Dec 15, 2025
Merged
Conversation
This was referenced Dec 8, 2025
Remove check for Mozilla as new versions of Chrome are reported as effected.
Contributor
Author
|
@tchellomello Hello! When you have time could you take a look at this PR. Chrome is apparently now impacted by this as well and folks would like to get this in place for use downstream for Home Assistant etc. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First time contributing outside of work so apologies if I missed any steps in the process.
One device addition for one of my cameras to add the proper name and basic info. Nothing related to actual PTZ control functionality.
Primary purpose of this PR is to implement a forced fix for the responses provided by Ring for WebRTC offers in an appropriate location to hopefully resolve this issue anywhere this library is used.
Tested on my HomeAssistant instance and after a bit of debugging was able to get it working.
If working as implemented and incorporated downstream, should fix the following:
#485
home-assistant/core#138821
Thanks to TeejMcSteez for this downstream workaround implementing the same fix in a quick and dirty fashion.
https://github.com/TeejMcSteez/HAWebRTCFix/tree/master