[builtins] Relax frozenset.isdisjoint method to accept Iterable[object]#15381
Open
Sachaa-Thanasius wants to merge 1 commit intopython:mainfrom
Open
[builtins] Relax frozenset.isdisjoint method to accept Iterable[object]#15381Sachaa-Thanasius wants to merge 1 commit intopython:mainfrom
Sachaa-Thanasius wants to merge 1 commit intopython:mainfrom
Conversation
This comment has been minimized.
This comment has been minimized.
Related to python#15271. This prevents false positives, and it is anyhow a better match for what the runtime accepts.
Sachaa-Thanasius
force-pushed
the
relax-frozenset-method-parameter-types
branch
from
42602df to
bcf70ef
Compare
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
14 tasks
Sachaa-Thanasius
changed the title
Sachaa-Thanasius
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #15271.
This prevents false positives, and it is anyhow a better match for what the runtime accepts.
Additionally,
set.isdisjointis currently annotated as acceptingIterable[Any]and seems to have been that way for years. I don't thinkAnyis better thanobjectthere or here, but I'm not certain.