gh-66305: Fix a hang on Windows in the tempfile module #144672
+61
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le module It occurred when trying to create a temporary file or subdirectory in a non-writable directory.
serhiy-storchaka
added
needs backport to 3.13
Member
Author
|
Reducing the number of attempts should help, but I have not tested yet. |
serhiy-storchaka
force-pushed
the
tempfile-hangs-on-bad-tempdir
branch
from
77ade1f to
ac17d9e
Compare
serhiy-storchaka
changed the title
Member
Author
|
Tested on Windows. There was a test for readonly tempdir, but it was always skipped on Windows. It was not for a few seconds, but for about 10 days (for estimations). Now the test correctly works on Windows. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It occurred when trying to create a temporary file or subdirectory in a non-writable directory.