Update wording after consulting product

Mark Phelps · Mark Phelps · commit dd5feda00a23 · 2022-02-25T17:32:08.000-05:00
diff --git a/pkg/cmd/codespace/create.go b/pkg/cmd/codespace/create.go
@@ -155,17 +155,17 @@ func (a *App) handleAdditionalPermissions(ctx context.Context, createParams *api
 		displayURL    = utils.DisplayURL(allowPermissionsURL)
 	)
 
-	fmt.Fprintf(a.io.ErrOut, "You must accept or deny additional permissions requested by the repository before you can create a codespace.\n")
+	fmt.Fprintf(a.io.ErrOut, "You must authorize or deny additional permissions requested by this codespace before continuing.\n")
 
 	if !isInteractive {
-		fmt.Fprintf(a.io.ErrOut, "%s to continue in your web browser to accept: %s\n", cs.Bold("Open this URL"), displayURL)
-		fmt.Fprintf(a.io.ErrOut, "Alternatively, you can run %q with the %q option to create the codespace without these additional permissions.\n", a.io.ColorScheme().Bold("create"), cs.Bold("--default-permissions"))
+		fmt.Fprintf(a.io.ErrOut, "%s in your browser to review and authorize additional permissions: %s\n", cs.Bold("Open this URL"), displayURL)
+		fmt.Fprintf(a.io.ErrOut, "Alternatively, you can run %q with the %q option to continue without authorizing additional permissions.\n", a.io.ColorScheme().Bold("create"), cs.Bold("--default-permissions"))
 		return nil, cmdutil.SilentError
 	}
 
 	choices := []string{
-		"Continue in browser to accept the additional permissions",
-		"Create the codespace without these additional permissions",
+		"Continue in browser to review and authorize additional permissions",
+		"Continue without authorizing additional permissions",
 	}
 
 	permsSurvey := []*survey.Question{
diff --git a/pkg/cmd/codespace/create_test.go b/pkg/cmd/codespace/create_test.go
@@ -116,9 +116,9 @@ func TestApp_Create(t *testing.T) {
 				idleTimeout: 30 * time.Minute,
 			},
 			wantErr: cmdutil.SilentError,
-			wantStderr: `You must accept or deny additional permissions requested by the repository before you can create a codespace.
-Open this URL to continue in your web browser to accept: example.com/permissions
-Alternatively, you can run "create" with the "--default-permissions" option to create the codespace without these additional permissions.
+			wantStderr: `You must authorize or deny additional permissions requested by this codespace before continuing.
+Open this URL in your browser to review and authorize additional permissions: example.com/permissions
+Alternatively, you can run "create" with the "--default-permissions" option to continue without authorizing additional permissions.
 `,
 		},
 	}

Original file line number	Diff line number	Diff line change
`@@ -155,17 +155,17 @@ func (a App) handleAdditionalPermissions(ctx context.Context, createParams api`
`155`	`155`	`displayURL = utils.DisplayURL(allowPermissionsURL)`
`156`	`156`	`)`
`157`	`157`
`158`		`- fmt.Fprintf(a.io.ErrOut, "You must accept or deny additional permissions requested by the repository before you can create a codespace.\n")`
	`158`	`+ fmt.Fprintf(a.io.ErrOut, "You must authorize or deny additional permissions requested by this codespace before continuing.\n")`
`159`	`159`
`160`	`160`	`if !isInteractive {`
`161`		`- fmt.Fprintf(a.io.ErrOut, "%s to continue in your web browser to accept: %s\n", cs.Bold("Open this URL"), displayURL)`
`162`		`- fmt.Fprintf(a.io.ErrOut, "Alternatively, you can run %q with the %q option to create the codespace without these additional permissions.\n", a.io.ColorScheme().Bold("create"), cs.Bold("--default-permissions"))`
	`161`	`+ fmt.Fprintf(a.io.ErrOut, "%s in your browser to review and authorize additional permissions: %s\n", cs.Bold("Open this URL"), displayURL)`
	`162`	`+ fmt.Fprintf(a.io.ErrOut, "Alternatively, you can run %q with the %q option to continue without authorizing additional permissions.\n", a.io.ColorScheme().Bold("create"), cs.Bold("--default-permissions"))`
`163`	`163`	`return nil, cmdutil.SilentError`
`164`	`164`	`}`
`165`	`165`
`166`	`166`	`choices := []string{`
`167`		`- "Continue in browser to accept the additional permissions",`
`168`		`- "Create the codespace without these additional permissions",`
	`167`	`+ "Continue in browser to review and authorize additional permissions",`
	`168`	`+ "Continue without authorizing additional permissions",`
`169`	`169`	`}`
`170`	`170`
`171`	`171`	`permsSurvey := []*survey.Question{`