fix(@angular/cli): exit with error code if unknown option is present

clydin · hansl · commit b5d9ac694b02 · 2018-06-05T17:55:19.000-07:00
diff --git a/packages/angular/cli/models/architect-command.ts b/packages/angular/cli/models/architect-command.ts
@@ -182,18 +182,17 @@ export abstract class ArchitectCommand extends Command<ArchitectCommandOptions>
             if (unknownProperty in options) {
               const dashes = unknownProperty.length === 1 ? '-' : '--';
               this.logger.fatal(`Unknown option: '${dashes}${unknownProperty}'`);
+              continue;
             }
           }
           newErrors.push(schemaError);
         }
 
         if (newErrors.length > 0) {
           this.logger.error(new schema.SchemaValidationException(newErrors).message);
-
-          return 1;
         }
 
-        return 0;
+        return 1;
       } else {
         throw e;
       }
diff --git a/tests/legacy-cli/e2e/tests/commands/unknown-option.ts b/tests/legacy-cli/e2e/tests/commands/unknown-option.ts
@@ -2,11 +2,17 @@ import { execAndWaitForOutputToMatch, ng } from '../../utils/process';
 import { expectToFail } from '../../utils/utils';
 
 export default async function() {
-  // await expectToFail(() => ng('build', '--notanoption'));
+  await expectToFail(() => ng('build', '--notanoption'));
 
   await execAndWaitForOutputToMatch(
     'ng',
     [ 'build', '--notanoption' ],
     /Unknown option: '--notanoption'/,
   );
+
+  await expectToFail(() => execAndWaitForOutputToMatch(
+    'ng',
+    [ 'build', '--notanoption' ],
+    /should NOT have additional properties\(notanoption\)./,
+  ));
 }

Original file line number	Diff line number	Diff line change
`@@ -182,18 +182,17 @@ export abstract class ArchitectCommand extends Command<ArchitectCommandOptions>`
`182`	`182`	`if (unknownProperty in options) {`
`183`	`183`	`const dashes = unknownProperty.length === 1 ? '-' : '--';`
`184`	`184`	this.logger.fatal(`Unknown option: '${dashes}${unknownProperty}'`);
	`185`	`+ continue;`
`185`	`186`	`}`
`186`	`187`	`}`
`187`	`188`	`newErrors.push(schemaError);`
`188`	`189`	`}`
`189`	`190`
`190`	`191`	`if (newErrors.length > 0) {`
`191`	`192`	`this.logger.error(new schema.SchemaValidationException(newErrors).message);`
`192`		`-`
`193`		`- return 1;`
`194`	`193`	`}`
`195`	`194`
`196`		`- return 0;`
	`195`	`+ return 1;`
`197`	`196`	`} else {`
`198`	`197`	`throw e;`
`199`	`198`	`}`