Replace some 'skipIf(not …)' by 'skipUnless'.

Trundle · Trundle · commit 94bb6571f7f7 · 2015-02-07T00:10:05.000+01:00
diff --git a/bpython/test/test_crashers.py b/bpython/test/test_crashers.py
@@ -128,7 +128,7 @@ class CursesCrashersTest(TrialTestCase, CrashersTest):
     backend = "cli"
 
 
-@unittest.skipIf(not have_urwid, "urwid is not available")
+@unittest.skipUnless(have_urwid, "urwid is required")
 @unittest.skipIf(reactor is None, "twisted is not available")
 class UrwidCrashersTest(TrialTestCase, CrashersTest):
     backend = "urwid"
diff --git a/bpython/test/test_curtsies_repl.py b/bpython/test/test_curtsies_repl.py
@@ -59,8 +59,8 @@ def test_external_communication(self):
         self.repl.send_current_block_to_external_editor()
         self.repl.send_session_to_external_editor()
 
-    @unittest.skipIf(not all(map(config.can_encode, 'å∂ßƒ')),
-                     'Charset can not encode characters')
+    @unittest.skipUnless(all(map(config.can_encode, 'å∂ßƒ')),
+                         'Charset can not encode characters')
     def test_external_communication_encoding(self):
         with captured_output():
             self.repl.display_lines.append('>>> "åß∂ƒ"')
@@ -291,15 +291,15 @@ def assert_pager_gets_unicode(self, text):
     def test_help(self):
         self.repl.pager(self.repl.help_text())
 
-    @unittest.skipIf(not all(map(config.can_encode, 'å∂ßƒ')),
-                     'Charset can not encode characters')
+    @unittest.skipUnless(all(map(config.can_encode, 'å∂ßƒ')),
+                         'Charset can not encode characters')
     def test_show_source_not_formatted(self):
         self.repl.config.highlight_show_source = False
         self.repl.get_source_of_current_name = lambda: 'source code å∂ßƒåß∂ƒ'
         self.repl.show_source()
 
-    @unittest.skipIf(not all(map(config.can_encode, 'å∂ßƒ')),
-                     'Charset can not encode characters')
+    @unittest.skipUnless(all(map(config.can_encode, 'å∂ßƒ')),
+                         'Charset can not encode characters')
     def test_show_source_formatted(self):
         self.repl.config.highlight_show_source = True
         self.repl.get_source_of_current_name = lambda: 'source code å∂ßƒåß∂ƒ'
diff --git a/bpython/test/test_filewatch.py b/bpython/test/test_filewatch.py
@@ -14,7 +14,7 @@
 
 from bpython.test import mock
 
-@unittest.skipIf(not has_watchdog, "watchdog not available")
+@unittest.skipUnless(has_watchdog, "watchdog required")
 class TestModuleChangeEventHandler(unittest.TestCase):
 
     def setUp(self):
