PMD: Consider simply returning the value vs storing it in local variable 'message'

KostyaSha · KostyaSha · commit 7452d6d1afa2 · 2015-10-10T17:13:51.000+03:00
diff --git a/src/main/java/com/github/dockerjava/jaxrs/filter/ResponseStatusExceptionFilter.java b/src/main/java/com/github/dockerjava/jaxrs/filter/ResponseStatusExceptionFilter.java
@@ -83,8 +83,7 @@ private String getBodyAsMessage(ClientResponseContext responseContext) throws IO
                 if (charset == null) {
                     charset = Charset.defaultCharset();
                 }
-                String message = new String(buffer, charset);
-                return message;
+                return new String(buffer, charset);
             }
         }
         return null;

Original file line number	Diff line number	Diff line change
`@@ -83,8 +83,7 @@ private String getBodyAsMessage(ClientResponseContext responseContext) throws IO`
`83`	`83`	`if (charset == null) {`
`84`	`84`	`charset = Charset.defaultCharset();`
`85`	`85`	`}`
`86`		`- String message = new String(buffer, charset);`
`87`		`- return message;`
	`86`	`+ return new String(buffer, charset);`
`88`	`87`	`}`
`89`	`88`	`}`
`90`	`89`	`return null;`