Mercurial > p > roundup > code
changeset 8459:db435e272f26
fix: update updating.txt doc for user_src_input bug
I originally thought it was not worth documenting because the error
case had no impact. But deployed copies of the trackers can be updated
to reduce differences between deployed and distributed files.
| author | John Rouillard <rouilj@ieee.org> |
|---|---|
| date | Fri, 26 Sep 2025 16:08:30 -0400 |
| parents | 15a92b0a9b79 |
| children | f72381d300a4 |
| files | CHANGES.txt doc/upgrading.txt |
| diffstat | 2 files changed, 23 insertions(+), 1 deletions(-) [+] |
line wrap: on
line diff
--- a/CHANGES.txt Thu Sep 25 23:30:07 2025 -0400 +++ b/CHANGES.txt Fri Sep 26 16:08:30 2025 -0400 @@ -31,7 +31,9 @@ command line always worked. (John Rouillard) - enhanced error reporting for errors in ini style logging configuration. (John Rouillard) - +- fix bogus javascript emitted by user_src_input macro. (John + Rouillard) + Features: - add support for authorized changes. User can be prompted to enter
--- a/doc/upgrading.txt Thu Sep 25 23:30:07 2025 -0400 +++ b/doc/upgrading.txt Fri Sep 26 16:08:30 2025 -0400 @@ -177,6 +177,26 @@ You can read about the details in the :ref:`admin manual <dictLogConfig>`. +Fix user.item.html template producing invalid Javascript (optional) +------------------------------------------------------------------- + +The html template ``page.html`` in the classic, devel, minimal, and +responsive tracker templates define a ``user_src_input`` macro. This +macro produces invalid javascript for the ``onblur`` event when used +by ``user.item.html``. The only effect from this bug is a javascript +error reported in the user's browser when the user does not have edit +permissions on the page. It doesn't have any user visible impact. + +If you want to fix this, replace:: + + tal:attributes="onblur python:edit_ok and 'split_name(this)'; + +with:: + + tal:attributes="onblur python:'split_name(this)' if edit_ok else ''; + +in the ``html/page.html`` file in your tracker. + .. index:: Upgrading; 2.4.0 to 2.5.0 Migrating from 2.4.0 to 2.5.0