Mercurial > p > roundup > code
changeset 7773:ac2c034542e6
chore: reduce nesting if/elif/else blocks; uneeded var assignment
also add lint hint
Leave chained if/elif/else blocks after returns if it doesn't reduce
nesting.
| author | John Rouillard <rouilj@ieee.org> |
|---|---|
| date | Sat, 02 Mar 2024 13:48:40 -0500 |
| parents | 6a1c1cd69582 |
| children | 60a6d50298c4 |
| files | roundup/admin.py |
| diffstat | 1 files changed, 15 insertions(+), 16 deletions(-) [+] |
line wrap: on
line diff
--- a/roundup/admin.py Sat Mar 02 13:45:29 2024 -0500 +++ b/roundup/admin.py Sat Mar 02 13:48:40 2024 -0500 @@ -1498,18 +1498,18 @@ raise UsageError(_( 'Argument must be setting=value, was given: %s.') % args[0]) - else: - print(_("Current settings and values " - "(NYI - not yet implemented):")) - is_verbose = self.settings['verbose'] - for key in sorted(self.settings.keys()): - if key.startswith('_') and not is_verbose: - continue - print(" %s=%s" % (key, self.settings[key])) - if is_verbose: - print(" %s" % self.settings_help[key]) - return + print(_("Current settings and values " + "(NYI - not yet implemented):")) + is_verbose = self.settings['verbose'] + for key in sorted(self.settings.keys()): + if key.startswith('_') and not is_verbose: + continue + print(" %s=%s" % (key, self.settings[key])) + if is_verbose: + print(" %s" % self.settings_help[key]) + + return if setting not in self.settings: raise UsageError(_('Unknown setting %s. Try "pragma list".') @@ -1720,8 +1720,8 @@ for p in permission.properties: if p in class_props: continue - else: - bad_props.append(p) + + bad_props.append(p) if bad_props: sys.stdout.write(_( '\n **Invalid properties for %(class)s: ' @@ -2012,8 +2012,7 @@ if command in ['genconfig', 'templates']: try: - ret = function(args[1:]) - return ret + return function(args[1:]) except UsageError as message: return self.usageError_feedback(message, function) @@ -2135,7 +2134,7 @@ self.print_designator = 0 self.verbose = 0 for opt, arg in opts: - if opt == '-h': + if opt == '-h': # noqa: RET505 - allow elif after returns self.usage() return 0 elif opt == '-v':