changeset 3023:a25de53435b1

don't set the title to nothing from incoming mail (thanks Bruce Guenter)
author Richard Jones <richard@users.sourceforge.net>
date Mon, 03 Jan 2005 02:52:00 +0000
parents 9523de67ecad
children 7032b500b7e0
files CHANGES.txt doc/index.txt roundup/mailgw.py
diffstat 3 files changed, 8 insertions(+), 3 deletions(-) [+]
line wrap: on
line diff
--- a/CHANGES.txt	Wed Dec 22 06:58:36 2004 +0000
+++ b/CHANGES.txt	Mon Jan 03 02:52:00 2005 +0000
@@ -64,6 +64,8 @@
 - fix typo (sf patch 1076629)
 - fix hyperlinking of items (sf bug 1080251)
 - fix roundup-admin find command handling of Multilinks
+- fix some security assertions (sf bug 1085481)
+- don't set the title to nothing from incoming mail (thanks Bruce Guenter)
 
 
 2004-10-26 0.7.9
--- a/doc/index.txt	Wed Dec 22 06:58:36 2004 +0000
+++ b/doc/index.txt	Mon Jan 03 02:52:00 2005 +0000
@@ -91,6 +91,7 @@
 Dan Grassi,
 Robin Green,
 Engelbert Gruber,
+Bruce Guenter,
 Juergen Hermann,
 Uwe Hoffmann,
 Tobias Hunger,
--- a/roundup/mailgw.py	Wed Dec 22 06:58:36 2004 +0000
+++ b/roundup/mailgw.py	Mon Jan 03 02:52:00 2005 +0000
@@ -72,7 +72,7 @@
 an exception, the original message is bounced back to the sender with the
 explanatory message given in the exception.
 
-$Id: mailgw.py,v 1.159 2004-11-17 22:16:29 richard Exp $
+$Id: mailgw.py,v 1.160 2005-01-03 02:52:00 richard Exp $
 """
 __docformat__ = 'restructuredtext'
 
@@ -845,8 +845,10 @@
 
 
         # set the issue title to the subject
-        if properties.has_key('title') and not issue_props.has_key('title'):
-            issue_props['title'] = title.strip()
+        title = title.strip()
+        if (title and properties.has_key('title') and not
+                issue_props.has_key('title')):
+            issue_props['title'] = title
 
         #
         # handle message-id and in-reply-to

Roundup Issue Tracker: http://roundup-tracker.org/