Mercurial > p > roundup > code
changeset 4578:941681fec1b0
issue2550711 Fix XSS vulnerability in @action parameter.
thanks to "om" for reporting.
Also fix issue number of previous change-entry.
| author | Ralf Schlatterbeck <rsc@runtux.com> |
|---|---|
| date | Thu, 05 Jan 2012 16:22:27 +0100 |
| parents | 528fe0a3af24 |
| children | ba4c632143f6 |
| files | CHANGES.txt doc/acknowledgements.txt roundup/cgi/client.py |
| diffstat | 3 files changed, 5 insertions(+), 2 deletions(-) [+] |
line wrap: on
line diff
--- a/CHANGES.txt Thu Jan 05 15:56:15 2012 +0100 +++ b/CHANGES.txt Thu Jan 05 16:22:27 2012 +0100 @@ -55,8 +55,10 @@ backported version of my proposed changes to email.header.decode_header in http://bugs.python.org/issue1079 (Ralf) -- issue2550711 Fix XSS vulnerability when username contains HTML code, +- issue2550684 Fix XSS vulnerability when username contains HTML code, thanks to Thomas Arendsen Hein for reporting and patch. +- issue2550711 Fix XSS vulnerability in @action parameter, + thanks to "om" for reporting. 2011-07-15: 1.4.19
--- a/doc/acknowledgements.txt Thu Jan 05 15:56:15 2012 +0100 +++ b/doc/acknowledgements.txt Thu Jan 05 16:22:27 2012 +0100 @@ -104,6 +104,7 @@ Truls E. Næss, Bryce L Nordgren, Patrick Ohly, +"om", Luke Opperman, Eddie Parker, Will Partain,
--- a/roundup/cgi/client.py Thu Jan 05 15:56:15 2012 +0100 +++ b/roundup/cgi/client.py Thu Jan 05 16:22:27 2012 +0100 @@ -1171,7 +1171,7 @@ if name == action_name: break else: - raise ValueError('No such action "%s"'%action_name) + raise ValueError('No such action "%s"'%cgi.escape(action_name)) return action_klass def _socket_op(self, call, *args, **kwargs):