Mercurial > p > roundup > code
changeset 3605:91c759d9271d
dangling connections in session handling [SF#1463359]
| author | Richard Jones <richard@users.sourceforge.net> |
|---|---|
| date | Thu, 27 Apr 2006 03:48:41 +0000 |
| parents | ccf516e6c3f8 |
| children | 04dc3eef67b7 |
| files | CHANGES.txt roundup/cgi/client.py |
| diffstat | 2 files changed, 5 insertions(+), 3 deletions(-) [+] |
line wrap: on
line diff
--- a/CHANGES.txt Thu Apr 27 03:44:47 2006 +0000 +++ b/CHANGES.txt Thu Apr 27 03:48:41 2006 +0000 @@ -15,6 +15,7 @@ - verbose output during import is optional now (sf bug 1475624) - escape *all* uses of "schema" in mysql backend (sf bug 1472120) - responses to user rego email (sf bug 1470254) +- dangling connections in session handling (sf bug 1463359) 2006-03-03 1.1.1
--- a/roundup/cgi/client.py Thu Apr 27 03:44:47 2006 +0000 +++ b/roundup/cgi/client.py Thu Apr 27 03:48:41 2006 +0000 @@ -1,4 +1,4 @@ -# $Id: client.py,v 1.223 2006-02-12 11:00:23 a1s Exp $ +# $Id: client.py,v 1.224 2006-04-27 03:48:41 richard Exp $ """WWW request handler (also used in the stand-alone server). """ @@ -458,8 +458,8 @@ user = username # if user was not set by http authorization, try session cookie - if (not user) and self.cookie.has_key(self.cookie_name) \ - and (self.cookie[self.cookie_name].value != 'deleted'): + if (not user and self.cookie.has_key(self.cookie_name) + and (self.cookie[self.cookie_name].value != 'deleted')): # get the session key from the cookie self.session = self.cookie[self.cookie_name].value # get the user from the session @@ -467,6 +467,7 @@ # update the lifetime datestamp sessions.updateTimestamp(self.session) user = sessions.get(self.session, 'user') + self.db.commit() except KeyError: # not valid, ignore id pass