changeset 1972:73989dcf020b maint-0.6

backport from HEAD
author Richard Jones <richard@users.sourceforge.net>
date Sat, 17 Jan 2004 01:50:03 +0000
parents 52d77d3be040
children d773a3849139
files CHANGES.txt templates/classic/html/help_controls.js
diffstat 2 files changed, 5 insertions(+), 3 deletions(-) [+]
line wrap: on
line diff
--- a/CHANGES.txt	Sat Jan 17 01:46:26 2004 +0000
+++ b/CHANGES.txt	Sat Jan 17 01:50:03 2004 +0000
@@ -11,6 +11,7 @@
 - fixed content-type when templates are serving up xml (thanks Godefroid
   Chapelle)
 - fixed IE double-submit when it shouldn't (sf bug 842254)
+- fixed check for JS pop()/push() to make more general (sf bug 877504)
 
 
 2003-12-17 0.6.4
--- a/templates/classic/html/help_controls.js	Sat Jan 17 01:46:26 2004 +0000
+++ b/templates/classic/html/help_controls.js	Sat Jan 17 01:50:03 2004 +0000
@@ -35,10 +35,11 @@
   }
 }
 
-// add the pop() and push() method to Array prototype for old IE browser
-if (bName() == 1 && bVer() >= 5.5);
-else {
+// add the pop() and push() method to Array if they're not there
+if (!Array.prototype.pop) {
     Array.prototype.pop = pop;
+}
+if (!Array.prototype.push) {
     Array.prototype.push = push;
 }
 

Roundup Issue Tracker: http://roundup-tracker.org/