Mercurial > p > roundup > code
changeset 6350:6a69584d117e
Remove length checks. We check list content explicitly.
So the length checks are redundant.
| author | John Rouillard <rouilj@ieee.org> |
|---|---|
| date | Sat, 27 Mar 2021 11:55:19 -0400 |
| parents | c1a672b1ad85 |
| children | 0db59cc2cd37 |
| files | test/rest_common.py |
| diffstat | 1 files changed, 1 insertions(+), 5 deletions(-) [+] |
line wrap: on
line diff
--- a/test/rest_common.py Sat Mar 27 00:03:30 2021 -0400 +++ b/test/rest_common.py Sat Mar 27 11:55:19 2021 -0400 @@ -2973,7 +2973,6 @@ results = self.server.get_element('issue', issue_id, self.terse_form) results = results['data'] self.assertEqual(self.dummy_client.response_code, 200) - self.assertEqual(len(results['attributes']['nosy']), 2) self.assertListEqual(results['attributes']['nosy'], ['1', '2']) etag = calculate_etag(self.db.issue.getnode(issue_id), @@ -2991,9 +2990,9 @@ results = self.server.get_element('issue', issue_id, self.terse_form) results = results['data'] self.assertEqual(self.dummy_client.response_code, 200) - self.assertEqual(len(results['attributes']['nosy']), 3) self.assertListEqual(results['attributes']['nosy'], ['1', '2', '3']) + # patch with no new_val/data etag = calculate_etag(self.db.issue.getnode(issue_id), self.db.config['WEB_SECRET_KEY']) @@ -3010,7 +3009,6 @@ results = self.server.get_element('issue', issue_id, self.terse_form) results = results['data'] self.assertEqual(self.dummy_client.response_code, 200) - self.assertEqual(len(results['attributes']['nosy']), 3) self.assertListEqual(results['attributes']['nosy'], ['1', '2', '3']) # patch invalid property @@ -3057,7 +3055,6 @@ results = results['data'] self.assertEqual(self.dummy_client.response_code, 200) self.assertEqual(results['attributes']['status'], '1') - self.assertEqual(len(results['attributes']['nosy']), 1) self.assertListEqual(results['attributes']['nosy'], ['1']) # replace userid 2 to the nosy list and status = 3 @@ -3077,7 +3074,6 @@ results = results['data'] self.assertEqual(self.dummy_client.response_code, 200) self.assertEqual(results['attributes']['status'], '3') - self.assertEqual(len(results['attributes']['nosy']), 1) self.assertListEqual(results['attributes']['nosy'], ['2']) # replace status = 2 using status attribute