changeset 3370:632ccccc2aec maint-0.8

merge from HEAD
author Richard Jones <richard@users.sourceforge.net>
date Fri, 24 Jun 2005 07:07:24 +0000
parents 246fed02a51e
children 086c634156e6
files CHANGES.txt doc/index.txt roundup/cgi/templating.py
diffstat 3 files changed, 6 insertions(+), 1 deletions(-) [+]
line wrap: on
line diff
--- a/CHANGES.txt	Fri Jun 24 06:48:17 2005 +0000
+++ b/CHANGES.txt	Fri Jun 24 07:07:24 2005 +0000
@@ -19,6 +19,7 @@
   popups (sf bug 1211800)
 - handle dropped properies in rdbms/metakit journal export (sf bug 1203569)
 - handle missing Subject lines better (sf bug 1198729)
+- sort/group by missing values correctly (sf bug 1198623)
 
 
 2005-05-02 0.8.3
--- a/doc/index.txt	Fri Jun 24 06:48:17 2005 +0000
+++ b/doc/index.txt	Fri Jun 24 07:07:24 2005 +0000
@@ -146,6 +146,7 @@
 Mitchell Surface,
 Mike Thompson,
 Michael Twomey,
+Karl Ulbrich,
 Martin Uzak,
 Darryl VanDorp,
 J Vickroy,
--- a/roundup/cgi/templating.py	Fri Jun 24 06:48:17 2005 +0000
+++ b/roundup/cgi/templating.py	Fri Jun 24 07:07:24 2005 +0000
@@ -2325,8 +2325,11 @@
         ''' Detect if the property marked as being the group property
             changed in the last iteration fetch
         '''
+        # we poke directly at the _value here since MissingValue can screw
+        # us up and cause Nones to compare strangely
         if (self.last_item is None or
-                self.last_item[property] != self.current_item[property]):
+                self.last_item[property]._value !=
+                self.current_item[property]._value):
             return 1
         return 0
 

Roundup Issue Tracker: http://roundup-tracker.org/