changeset 1829:4e4afbe3cd30

Move '<input type="hidden">' elements into a block. It is invalid HTML4 Strict to have them at the top of a form.
author Johannes Gijsbers <jlgijsbers@users.sourceforge.net>
date Fri, 03 Oct 2003 19:15:24 +0000
parents b4ba6db03595
children 4ac11e7fa11a
files doc/customizing.txt templates/classic/html/file.item.html templates/classic/html/issue.item.html templates/classic/html/issue.search.html templates/classic/html/keyword.item.html templates/classic/html/user.forgotten.html templates/classic/html/user.item.html templates/classic/html/user.register.html
diffstat 8 files changed, 47 insertions(+), 35 deletions(-) [+]
line wrap: on
line diff
--- a/doc/customizing.txt	Fri Oct 03 19:13:50 2003 +0000
+++ b/doc/customizing.txt	Fri Oct 03 19:15:24 2003 +0000
@@ -2,7 +2,7 @@
 Customising Roundup
 ===================
 
-:Version: $Revision: 1.101 $
+:Version: $Revision: 1.102 $
 
 .. This document borrows from the ZopeBook section on ZPT. The original is at:
    http://www.zope.org/Documentation/Books/ZopeBook/current/ZPT.stx
@@ -2373,8 +2373,6 @@
    <form method="POST" onSubmit="return submit_once()"
          enctype="multipart/form-data">
 
-    <input type="hidden" name="@required" value="name">
-
     <table class="form">
      <tr><th class="header" colspan="2">Category</th></tr>
 
@@ -2385,7 +2383,10 @@
      </tr>
 
      <tr>
-      <td>&nbsp;</td>
+      <td>
+        &nbsp;
+        <input type="hidden" name="@required" value="name"> 
+      </td>
       <td colspan="3" tal:content="structure context/submit">
        submit button will go here
       </td>
--- a/templates/classic/html/file.item.html	Fri Oct 03 19:13:50 2003 +0000
+++ b/templates/classic/html/file.item.html	Fri Oct 03 19:15:24 2003 +0000
@@ -13,13 +13,6 @@
 <form method="POST" onSubmit="return submit_once()"
       enctype="multipart/form-data" tal:condition="context/is_edit_ok">
 
-<input type="hidden" name=":template" value="item">
-<input type="hidden" name=":required" value="name,type">
-
-<input type="hidden" name=":multilink"
-       tal:condition="python:request.form.has_key(':multilink')"
-       tal:attributes="value request/form/:multilink/value">
-
 <table class="form">
  <tr>
   <th>Name</th>
@@ -31,7 +24,14 @@
  </tr>
 
  <tr>
-  <td>&nbsp;</td>
+  <td>
+   &nbsp;
+   <input type="hidden" name=":template" value="item">
+   <input type="hidden" name=":required" value="name,type">
+   <input type="hidden" name=":multilink"
+          tal:condition="python:request.form.has_key(':multilink')"
+          tal:attributes="value request/form/:multilink/value">
+  </td>
   <td tal:content="structure context/submit">submit button here</td>
  </tr>
 </table>
--- a/templates/classic/html/issue.item.html	Fri Oct 03 19:13:50 2003 +0000
+++ b/templates/classic/html/issue.item.html	Fri Oct 03 19:15:24 2003 +0000
@@ -23,9 +23,6 @@
       enctype="multipart/form-data" tal:condition="context/is_edit_ok"
       tal:attributes="action context/designator">
 
-<input type="hidden" name=":template" value="item">
-<input type="hidden" name=":required" value="title,priority">
-
 <table class="form">
 <tr>
  <th class="required">Title</th>
@@ -81,7 +78,11 @@
 </tr>
 
 <tr>
- <td>&nbsp;</td>
+ <td>
+  &nbsp;
+  <input type="hidden" name=":template" value="item">
+  <input type="hidden" name=":required" value="title,priority">
+ </td>
  <td colspan=3 tal:content="structure context/submit">
   submit button will go here
  </td>
--- a/templates/classic/html/issue.search.html	Fri Oct 03 19:13:50 2003 +0000
+++ b/templates/classic/html/issue.search.html	Fri Oct 03 19:15:24 2003 +0000
@@ -6,7 +6,6 @@
 <td class="content" metal:fill-slot="content">
 
 <form method="GET" tal:attributes="action request/classname">
-<input type="hidden" name=":action" value="search">
 
 <table class="form" tal:define="
    cols python:request.columns or 'id activity title status assignedto'.split();
@@ -168,7 +167,10 @@
 </tr>
 
 <tr>
-  <td>&nbsp;</td>
+  <td>
+   &nbsp;
+   <input type="hidden" name=":action" value="search">
+  </td>
   <td><input type="submit" value="Search"></td>
 </tr>
 
--- a/templates/classic/html/keyword.item.html	Fri Oct 03 19:13:50 2003 +0000
+++ b/templates/classic/html/keyword.item.html	Fri Oct 03 19:15:24 2003 +0000
@@ -31,9 +31,6 @@
 <form method="POST" onSubmit="return submit_once()"
       enctype="multipart/form-data">
 
- <input type="hidden" name=":required" value="name">
- <input type="hidden" name=":template" value="item">
-
  <table class="form">
   <tr>
    <th>Keyword</th>
@@ -41,7 +38,11 @@
   </tr>
 
   <tr>
-   <td>&nbsp;</td>
+   <td>
+    &nbsp;
+    <input type="hidden" name=":required" value="name">
+    <input type="hidden" name=":template" value="item">
+   </td>
    <td colspan=3 tal:content="structure context/submit">
     submit button will go here
    </td>
--- a/templates/classic/html/user.forgotten.html	Fri Oct 03 19:13:50 2003 +0000
+++ b/templates/classic/html/user.forgotten.html	Fri Oct 03 19:15:24 2003 +0000
@@ -10,11 +10,19 @@
 know the email address you registered with, enter it below.</p>
 
 <form method="POST" onSubmit="return submit_once()">
-<input type="hidden" name="@action" value="passrst">
-<input type="hidden" name="@template" value="forgotten">
-<table class="form">
- <tr><th>Email Address:</th> <td><input name="address"></td> </tr>
- <tr><td></td><td><input type="submit" value="Request password reset"></td></tr>
+    <table class="form">
+      <tr>
+        <th>Email Address:</th>
+        <td><input name="address"></td>
+      </tr>
+      <tr>
+        <td>&nbsp;</td>
+        <td>
+          <input type="hidden" name="@action" value="passrst">
+          <input type="hidden" name="@template" value="forgotten">
+          <input type="submit" value="Request password reset">
+        </td>
+      </tr>
 </table>
 
 <p>Or, if you know your username, then enter it below.</p>
--- a/templates/classic/html/user.item.html	Fri Oct 03 19:13:50 2003 +0000
+++ b/templates/classic/html/user.item.html	Fri Oct 03 19:15:24 2003 +0000
@@ -21,9 +21,6 @@
 <form method="POST" onSubmit="return submit_once()"
       enctype="multipart/form-data" tal:condition="context/is_edit_ok">
 
-<input type="hidden" name=":template" value="item">
-<input type="hidden" name=":required" value="username,address">
-
 <table class="form">
  <tr>
   <th>Name</th>
@@ -72,7 +69,11 @@
  </tr>
 
  <tr>
-  <td>&nbsp;</td>
+  <td>
+   &nbsp;
+   <input type="hidden" name=":template" value="item">
+   <input type="hidden" name=":required" value="username,address">
+  </td>
   <td tal:content="structure context/submit">submit button here</td>
  </tr>
 </table>
--- a/templates/classic/html/user.register.html	Fri Oct 03 19:13:50 2003 +0000
+++ b/templates/classic/html/user.register.html	Fri Oct 03 19:15:24 2003 +0000
@@ -16,10 +16,6 @@
 
 <tal:block tal:condition="editok">
 <form method="POST" onSubmit="return submit_once()" enctype="multipart/form-data">
-<input type="hidden" name=":template" value="register">
-<input type="hidden" name=":required" value="username">
-<input type="hidden" name=":required" value="password">
-<input type="hidden" name=":required" value="address">
 
 <table class="form">
  <tr>
@@ -66,6 +62,8 @@
  <tr>
   <td>&nbsp;</td>
   <td>
+   <input type="hidden" name=":template" value="register">
+   <input type="hidden" name=":required" value="username,password,address">
    <input type="hidden" name=":action" value="register">
    <input type="submit" name="submit" value="Register">
   </td>

Roundup Issue Tracker: http://roundup-tracker.org/