Mercurial > p > roundup > code
changeset 5251:35b30ce991d0
Suppress the "... - nothing changed" status banner presented when a
form is submitted. This is triggered only when only quiet properties
are changed.
See:
https://sourceforge.net/p/roundup/mailman/roundup-users/thread/20170421012107.E040180690%40vm71.cs.umb.edu/
with subject:
[Roundup-users] Does anybody think feedback saying "nothing changed" is useful?
| author | John Rouillard <rouilj@ieee.org> |
|---|---|
| date | Thu, 10 Aug 2017 22:35:05 -0400 |
| parents | 092c4522b3bf |
| children | 0b154486ed38 28b6bfd303c3 |
| files | roundup/cgi/actions.py |
| diffstat | 1 files changed, 7 insertions(+), 2 deletions(-) [+] |
line wrap: on
line diff
--- a/roundup/cgi/actions.py Wed May 10 10:53:16 2017 +0200 +++ b/roundup/cgi/actions.py Thu Aug 10 22:35:05 2017 -0400 @@ -633,8 +633,13 @@ self._('%(class)s %(id)s %(properties)s edited ok') % {'class':cn, 'id':nodeid, 'properties':info}) else: - m.append(self._('%(class)s %(id)s - nothing changed') - % {'class':cn, 'id':nodeid}) + # this used to produce a message like: + # issue34 - nothing changed + # which is confusing if only quiet properties + # changed for the class/id. So don't report + # anything is the user didn't explicitly change + # a visible (non-quiet) property. + pass else: assert props