changeset 8505:299edbd03ddf

bug: rearrange test condition to optimize test w/ most likely to fail first and expensive permission check last
author John Rouillard <rouilj@ieee.org>
date Tue, 23 Dec 2025 22:11:23 -0500
parents e331be9bc473
children b6c6891754e9
files roundup/cgi/client.py
diffstat 1 files changed, 3 insertions(+), 2 deletions(-) [+]
line wrap: on
line diff
--- a/roundup/cgi/client.py	Mon Dec 22 12:26:03 2025 -0500
+++ b/roundup/cgi/client.py	Tue Dec 23 22:11:23 2025 -0500
@@ -1404,8 +1404,9 @@
 
         # allow Anonymous to view the "user" "register" template if they're
         # allowed to register
-        if (self.db.security.hasPermission('Register', self.userid, 'user')
-                and self.classname == 'user' and self.template == 'register'):
+        if (self.template == 'register' and self.classname == 'user'
+            and self.db.security.hasPermission('Register',
+                                               self.userid, 'user')):
             return
 
         # otherwise for everything else

Roundup Issue Tracker: http://roundup-tracker.org/