changeset 6319:20e77c3ce6f6 issue2550923_computed_property

issue2551109 - improve keyword editing in jinja2 template.
author John Rouillard <rouilj@ieee.org>
date Fri, 15 Jan 2021 16:34:30 -0500
parents 325beb81c89d
children 1a15089c2e49
files CHANGES.txt share/roundup/templates/jinja2/html/keyword.item.html
diffstat 2 files changed, 19 insertions(+), 15 deletions(-) [+]
line wrap: on
line diff
--- a/CHANGES.txt	Mon Dec 21 00:46:35 2020 -0500
+++ b/CHANGES.txt	Fri Jan 15 16:34:30 2021 -0500
@@ -73,7 +73,7 @@
   available. (John Rouillard)
 - Added explanation for modifying Fileclass content files to
   customizing.txt. Result of mailing list question. (John Rouillard)
-
+- issue2551109 - improve keyword editing in jinja2 template.
 
 2020-07-13 2.0.0
 
--- a/share/roundup/templates/jinja2/html/keyword.item.html	Mon Dec 21 00:46:35 2020 -0500
+++ b/share/roundup/templates/jinja2/html/keyword.item.html	Fri Jan 15 16:34:30 2021 -0500
@@ -11,28 +11,32 @@
 {% block content %}
 
   <h4>Existing Keywords</h4>
+  <ul class='nav nav-pills nav-stacked'>
+    {% for keyword in db.keyword.list() %}
+      <li class='nav-item'>
+        <a class='nav-link {{ 'active' if context.id == keyword.id else '' }}' href='keyword{{ keyword.id }}'>{{ keyword.name.plain()|u }}</a>
+      </li>
+    {% else %}
+      <p class='text-mute'>{% trans %}There are no keywords yet.  Be the first -{% endtrans %}</p>
+    {% endfor %}
+    {% if context.id %}
+    <li class='nav-item'>
+      <a class='nav-link close' href='keyword?@template=item' aria-label="Close">
+        <span aria-hidden="true">&times;</span>
+      </a>
+    </li>
+    {% endif %}
+  </ul>
   <p class='text-warning'>
    {% trans %}To edit an existing keyword (for spelling or typing errors),
    click on its entry above.{% endtrans %}
   </p>
 
-  <ul class='nav nav-pills nav-stacked'>
-    {% for keyword in db.keyword.list() %}
-      <li>
-        <a href='keyword{{ keyword.id }}'>{{ keyword.name.plain()|u }}</a>
-      </li>
-    {% else %}
-      <p class='text-mute'>{% trans %}There are no keywords yet.  Be the first -{% endtrans %}</p>
-    {% endfor %}
-  </ul>
 
   <form class='form-inline' method="POST" action='{{ context.designator() }}'>
-    <input type='text' class='input-xlarge' name='name'>
+    <input type='text' class='input-xlarge' name='name' value='{{ context.name if context.id else '' }}'>
     <input type="hidden" name="@required" value="name">
     <input type="hidden" name="@template" value="item">
-    <input name="@csrf" type="hidden"
-           value="{{ utils.anti_csrf_nonce() }}">
-    <input type="hidden" name="@action" value="new">
-    <input type='submit' class='btn btn-primary' value="{% trans %}Create keyword{% endtrans %}">
+    {{ context.submit(html_kwargs={ 'class': 'btn btn-primary' })|u|safe }}
   </form>
 {% endblock %}

Roundup Issue Tracker: http://roundup-tracker.org/