Mercurial > p > roundup > code
changeset 3369:18f1631c9b85
sort/group by missing values correctly [SF#1198623]
| author | Richard Jones <richard@users.sourceforge.net> |
|---|---|
| date | Fri, 24 Jun 2005 07:06:14 +0000 |
| parents | a23863a95326 |
| children | 4f3285913a8c |
| files | CHANGES.txt doc/index.txt roundup/cgi/templating.py |
| diffstat | 3 files changed, 6 insertions(+), 1 deletions(-) [+] |
line wrap: on
line diff
--- a/CHANGES.txt Fri Jun 24 06:47:44 2005 +0000 +++ b/CHANGES.txt Fri Jun 24 07:06:14 2005 +0000 @@ -26,6 +26,7 @@ popups (sf bug 1211800) - handle dropped properies in rdbms/metakit journal export (sf bug 1203569) - handle missing Subject lines better (sf bug 1198729) +- sort/group by missing values correctly (sf bug 1198623) 2005-05-02 0.8.3
--- a/doc/index.txt Fri Jun 24 06:47:44 2005 +0000 +++ b/doc/index.txt Fri Jun 24 07:06:14 2005 +0000 @@ -146,6 +146,7 @@ Mitchell Surface, Mike Thompson, Michael Twomey, +Karl Ulbrich, Martin Uzak, Darryl VanDorp, J Vickroy,
--- a/roundup/cgi/templating.py Fri Jun 24 06:47:44 2005 +0000 +++ b/roundup/cgi/templating.py Fri Jun 24 07:06:14 2005 +0000 @@ -2341,8 +2341,11 @@ ''' Detect if the property marked as being the group property changed in the last iteration fetch ''' + # we poke directly at the _value here since MissingValue can screw + # us up and cause Nones to compare strangely if (self.last_item is None or - self.last_item[property] != self.current_item[property]): + self.last_item[property]._value != + self.current_item[property]._value): return 1 return 0