Mercurial > p > roundup > code
changeset 1765:14a2f1529759
fix CGI editCSV action to handle metakit's integer itemids
- apply fix for "remove" links from Klamer Schutte
- added permission check on "remove" link while I was there..
| author | Richard Jones <richard@users.sourceforge.net> |
|---|---|
| date | Thu, 28 Aug 2003 01:39:15 +0000 |
| parents | cd50fbc275a1 |
| children | fdaa0b751355 |
| files | CHANGES.txt doc/index.txt roundup/cgi/client.py templates/classic/html/issue.item.html |
| diffstat | 4 files changed, 12 insertions(+), 7 deletions(-) [+] |
line wrap: on
line diff
--- a/CHANGES.txt Wed Aug 27 17:34:57 2003 +0000 +++ b/CHANGES.txt Thu Aug 28 01:39:15 2003 +0000 @@ -7,6 +7,9 @@ - Importing wasn't setting None values explicitly when it should have been - Fixed import warning regarding 0xffff0000 literal, finally, really this time. Checked on win2k. (sf bug 786711) +- fix CGI editCSV action to handle metakit's integer itemids +- apply fix for "remove" links from Klamer Schutte +- added permission check on "remove" link while I was there.. 2003-08-08 0.6.0
--- a/doc/index.txt Wed Aug 27 17:34:57 2003 +0000 +++ b/doc/index.txt Thu Aug 28 01:39:15 2003 +0000 @@ -81,6 +81,7 @@ Dougal Scott, Stefan Seefeld, Jeffrey P Shell, +Klamer Schutte, Joel Shprentz, Terrel Shumway, Nathaniel Smith,
--- a/roundup/cgi/client.py Wed Aug 27 17:34:57 2003 +0000 +++ b/roundup/cgi/client.py Thu Aug 28 01:39:15 2003 +0000 @@ -1,4 +1,4 @@ -# $Id: client.py,v 1.130 2003-08-13 23:51:59 richard Exp $ +# $Id: client.py,v 1.131 2003-08-28 01:39:15 richard Exp $ __doc__ = """ WWW request handler (also used in the stand-alone server). @@ -995,14 +995,14 @@ try: props, links = self.parsePropsFromForm() except (ValueError, KeyError), message: - self.error_message.append(_('Error: ') + str(message)) + self.error_message.append(_('Parse Error: ') + str(message)) return # handle the props try: message = self._editnodes(props, links) except (ValueError, KeyError, IndexError), message: - self.error_message.append(_('Error: ') + str(message)) + self.error_message.append(_('Apply Error: ') + str(message)) return # commit now that all the tricky stuff is done @@ -1252,10 +1252,10 @@ found[nodeid] = 1 # see if the node exists - if cl.hasnode(nodeid): + if nodeid in ('x', 'X') or not cl.hasnode(nodeid): + exists = 0 + else: exists = 1 - else: - exists = 0 # confirm correct weight if len(idlessprops) != len(values):
--- a/templates/classic/html/issue.item.html Wed Aug 27 17:34:57 2003 +0000 +++ b/templates/classic/html/issue.item.html Thu Aug 28 01:39:15 2003 +0000 @@ -140,7 +140,8 @@ <th tal:content="string:Author: ${msg/author}">author</th> <th tal:content="string:Date: ${msg/date}">date</th> <th> - <a tal:attributes="href string:?:remove:messages=${msg/id}&:action=edit">remove</a> + <a tal:condition="context/is_edit_ok" + tal:attributes="href string:issue${context/id}?:remove:messages=${msg/id}&:action=edit">remove</a> </th> </tr> <tr>
