# HG changeset patch # User John Rouillard # Date 1714702297 14400 # Node ID c05ea62b4c7a71d9c300592ada956f997e2a3095 # Parent ea4e3dc4b59ede8d6242f07c36dd787024b11877 fix: issue2551347 - make _generic.help.html work without property settings This lets the classhelp() method run in read only mode to provide information on a Link property without updating the property. Updating the property can be done by selecting the proper value using the drop-down. Update classic and minimal templates to allow this to work. Update upgrading and reference docs. diff -r ea4e3dc4b59e -r c05ea62b4c7a CHANGES.txt --- a/CHANGES.txt Thu May 02 21:54:16 2024 -0400 +++ b/CHANGES.txt Thu May 02 22:11:37 2024 -0400 @@ -190,6 +190,12 @@ parameter. So you can start a demo tracker that is available from your network using 'roundup-demo ... -B hostname -H hostname'. (John Rouillard) +- issue2551347 - make _generic.help.html work without property + settings. THis applies to classic or minimal trackers. It allows use + of classhelp without the property seting for informtion only + (e.g. description of what a priority or status means) without being + able to select the property in the classhelper. Good for adding help + for Link properties. (John Rouilllard) 2023-07-13 2.3.0 diff -r ea4e3dc4b59e -r c05ea62b4c7a doc/reference.txt --- a/doc/reference.txt Thu May 02 21:54:16 2024 -0400 +++ b/doc/reference.txt Thu May 02 22:11:37 2024 -0400 @@ -2756,9 +2756,16 @@ The popup window is resizable and scrollable. - If the "property" arg is given, it's passed through to the - JavaScript help_window function. This allows updating of a - property in the calling HTML page. + If the "property" arg is given, it's passed through to + the JavaScript help_window function. This allows + updating of a property in the calling HTML + page. "property" is optional. If not provided, the + resulting window will be read only. This is useful for + Link properties where selection can be done by drop-down, + but descriptions of the values can be seen in the popup. + Note that some tracker templates may generate an error + if the property is missing. Version 2.4.0 of Roundup + fixed these templates. If the "form" arg is given, it's passed through to the JavaScript help_window function - it's the name of the form diff -r ea4e3dc4b59e -r c05ea62b4c7a doc/upgrading.txt --- a/doc/upgrading.txt Thu May 02 21:54:16 2024 -0400 +++ b/doc/upgrading.txt Thu May 02 22:11:37 2024 -0400 @@ -367,6 +367,20 @@ `issue2551320 `_ to fix your template. +Update for _generic.help.html (optional) +---------------------------------------- + +Using the ``_generic.help.html`` template with ``classhelper()`` to +provide information on a property without selecting a property caused +an error when processing the template. Using the help template with +Link properties can provide description or other information that the +user can use to determine the right setting. + +If your tracker is based on the minimal or classic tracker and you have +not changed the _generic.help.html file, you can copy it into place +from the template directory. + + Fix static_files use of '-' directory (info) -------------------------------------------- diff -r ea4e3dc4b59e -r c05ea62b4c7a share/roundup/templates/classic/html/_generic.help.html --- a/share/roundup/templates/classic/html/_generic.help.html Thu May 02 21:54:16 2024 -0400 +++ b/share/roundup/templates/classic/html/_generic.help.html Thu May 02 22:11:37 2024 -0400 @@ -1,12 +1,12 @@ - + <tal:x i18n:name="property" - tal:content="property" i18n:translate="" /> help - <span i18n:name="tracker" + tal:content="property | default" i18n:translate="" /> help - <span i18n:name="tracker" tal:replace="config/TRACKER_NAME" />