Mercurial > p > roundup > code
view website/wiki/static/roundup/css/msie.css @ 5548:fea11d05110e
Avoid errors from selecting "no selection" on multilink (issue2550722).
As discussed in issue 2550722 there are various cases where selecting
"no selection" on a multilink can result in inappropriate errors from
Roundup:
* If selecting "no selection" produces a null edit (a value was set in
the multilink in an edit with an error, then removed again, along
with all other changes, in the next form submission), so the page is
rendered from the form contents including the "-<id>" value for "no
selection" for the multilink.
* If creating an item with a nonempty value for a multilink has an
error, and the resubmission changes that multilink to "no selection"
(and this in turn has subcases, according to whether the creation
then succeeds or fails on the resubmission, which need fixes in
different places in the Roundup code).
All of these cases have in common that it is expected and OK to have a
"-<id>" value for a submission for a multilink when <id> is not set in
that multilink in the database (because the original attempt to set
<id> in that multilink had an error), so the hyperdb.py logic to give
an error in that case is thus removed. In the subcase of the second
case where the resubmission with "no selection" has an error, the
templating code tries to produce a menu entry for the "-<id>"
multilink value, which also results in an error, hence the
templating.py change to ignore such values in the list for a
multilink.
| author | Joseph Myers <jsm@polyomino.org.uk> |
|---|---|
| date | Thu, 27 Sep 2018 11:33:01 +0000 |
| parents | 86c38b5aed66 |
| children |
line wrap: on
line source
/* msie.css - MoinMoin MS Internet explorer bug workarounds */ /* IE6 and IE7 both suck with :before */ a.www { padding-left: 14px; background: url(../img/moin-www.png) left center no-repeat; } a.http { padding-left: 14px; background: url(../img/moin-www.png) left center no-repeat; } a.https { padding-left: 14px; background: url(../img/moin-www.png) left center no-repeat; } a.file { padding-left: 14px; background: url(../img/moin-ftp.png) left center no-repeat; } a.ftp { padding-left: 14px; background: url(../img/moin-ftp.png) left center no-repeat; } a.nntp { padding-left: 14px; background: url(../img/moin-news.png) left center no-repeat; } a.news { padding-left: 14px; background: url(../img/moin-news.png) left center no-repeat; } a.telnet, a.ssh { padding-left: 14px; background: url(../img/moin-telnet.png) left center no-repeat; } a.irc, a.ircs { padding-left: 14px; background: url(../img/moin-telnet.png) left center no-repeat; } a.mailto { padding-left: 14px; background: url(../img/moin-email.png) left center no-repeat; } a.attachment { padding-left: 14px; background: url(../img/moin-attach.png) left center no-repeat; } a.badinterwiki { padding-left: 14px; background: url(../img/moin-inter.png) left center no-repeat; } a.interwiki { padding-left: 14px; background: url(../img/moin-inter.png) left center no-repeat; } #message .warning { padding-left: 20px; background: url(../img/alert.png) left center no-repeat; } #message .error { padding-left: 20px; background: url(../img/icon-error.png) left center no-repeat; } #pagetrail li, #pagelocation li { border-left: 1px solid #AAA; padding: 0 0.3em; } /* Spans for line-anchors - needed for IE6 and IE7 where omitting the "display: none" triggers rendering bugs. */ span.anchor { display: none; } /* Fix for PeekABoo Bug */ #page { min-height: 1%; } /* Some * html hacks for IE6 and below only (IE7 ignores * html) */ /* IE6 has a bug with rendering of float elements. We workaround this bug by * assigning those elements a height attribute because we currently don't know * a better solution. This results in IE calculating the correct height of the * characters and displaying them correctly. We don't know any negative side * effects of this workaround: */ * html div#page, * html div#header { height: 0.001%; }