Mercurial > p > roundup > code
view website/issues/html/style.css @ 5548:fea11d05110e
Avoid errors from selecting "no selection" on multilink (issue2550722).
As discussed in issue 2550722 there are various cases where selecting
"no selection" on a multilink can result in inappropriate errors from
Roundup:
* If selecting "no selection" produces a null edit (a value was set in
the multilink in an edit with an error, then removed again, along
with all other changes, in the next form submission), so the page is
rendered from the form contents including the "-<id>" value for "no
selection" for the multilink.
* If creating an item with a nonempty value for a multilink has an
error, and the resubmission changes that multilink to "no selection"
(and this in turn has subcases, according to whether the creation
then succeeds or fails on the resubmission, which need fixes in
different places in the Roundup code).
All of these cases have in common that it is expected and OK to have a
"-<id>" value for a submission for a multilink when <id> is not set in
that multilink in the database (because the original attempt to set
<id> in that multilink had an error), so the hyperdb.py logic to give
an error in that case is thus removed. In the subcase of the second
case where the resubmission with "no selection" has an error, the
templating code tries to produce a menu entry for the "-<id>"
multilink value, which also results in an error, hence the
templating.py change to ignore such values in the list for a
multilink.
| author | Joseph Myers <jsm@polyomino.org.uk> |
|---|---|
| date | Thu, 27 Sep 2018 11:33:01 +0000 |
| parents | 26811e2031f6 |
| children | 4be81616e38a |
line wrap: on
line source
/* This is a copy of main Roundup website style.css from website/www/_static/style.css in source repository. */ /* layout*/ body { font-family: sans-serif, Arial, Helvetica; background-color: white; color: #333; margin:0; padding: 0 3em 0 13em; } body > .header { margin: 0 0 0 -13em;} body > .footer { margin: 0 0 0 -13em; clear:both;} body > .navigation { margin-left: -13em; width: 13em; float: left; } body > .content { width: 100%; margin: 0; } body > .header > #searchbox { position: absolute; right: 1em; top: 1em;} /* style */ :link { color: #bb0000; text-decoration: none;} :visited { color: #770000; text-decoration: none;} .header h1 { margin-left: 1em; } body { font-family: sans-serif, Arial, Helvetica; background-color: #f5f5f5; color: #333; } .menu { padding: 0; margin-right: 1em;} .menu ul { padding: 0; margin: 0; } .menu li { margin: 5pt 0; } .menu > ul > li > * { display: block; padding: 2pt 2pt 2pt 10pt; border: solid thin #dadada; background-color:#ffffff; } .menu > ul > li.current > * { background-color:#dddddd; } .menu ul li:first-child { margin-top:0;} .menu ul { list-style-type:none;} /* sub-menus are indented */ .menu > ul > li > ul, .menu > ul > li.current > ul { border: none; background-color: inherit; margin: 0; } .menu ul ul { margin-left: 2em; font-size: smaller; margin: 0 0 0 5pt; } /* sub-menu items draw a separator */ .menu ul ul > li { margin: 0; padding: 0; border: none; border-top: solid thin #dadada; background-color: inherit; } .menu ul ul > li:first-child { border-top: none; } .footer { font-size: small; text-align: center; color: lightgrey; } .content { padding: 1em; border: solid thin #dadada; background-color: #ffffff; } pre { white-space: pre-wrap; } #search { text-align: right; } p.ok-message { background-color: #eeffee; border: 1px solid #009900; padding: 5px; color: #009900; font-weight: bold; } p.error-message { background-color: #ffeeee; border: 1px solid #990000; padding: 5px; color: #990000; font-weight: bold; } /* This is a little hack to inject a 'news' block into the title page without having to set up a custom directive. */ #roundup-issue-tracker .note { float: right; width: auto; border: solid thin #dadada; background-color:#f5f5f5; padding: 1em; margin: 1em; } #roundup-issue-tracker .note .admonition-title { display: none; } table { border-collapse: collapse; border-spacing: 1px; background-color: #fafafa; } /* Need some space between content of Issue List columns */ td { padding-left: 1em; } tr.odd { background-color:#f5f5f5; } /* Make sure that user name starts at the top of the change list and not in the middle Issue2550809: History display misalignment */ table.history td { vertical-align: top; } /* similar issue as above with history table. Align labels to the left at the top of possible multiline description and other columns */ table.classhelp td { vertical-align: top; }
