view scripts/add-issue @ 5548:fea11d05110e

Avoid errors from selecting "no selection" on multilink (issue2550722). As discussed in issue 2550722 there are various cases where selecting "no selection" on a multilink can result in inappropriate errors from Roundup: * If selecting "no selection" produces a null edit (a value was set in the multilink in an edit with an error, then removed again, along with all other changes, in the next form submission), so the page is rendered from the form contents including the "-<id>" value for "no selection" for the multilink. * If creating an item with a nonempty value for a multilink has an error, and the resubmission changes that multilink to "no selection" (and this in turn has subcases, according to whether the creation then succeeds or fails on the resubmission, which need fixes in different places in the Roundup code). All of these cases have in common that it is expected and OK to have a "-<id>" value for a submission for a multilink when <id> is not set in that multilink in the database (because the original attempt to set <id> in that multilink had an error), so the hyperdb.py logic to give an error in that case is thus removed. In the subcase of the second case where the resubmission with "no selection" has an error, the templating code tries to produce a menu entry for the "-<id>" multilink value, which also results in an error, hence the templating.py change to ignore such values in the list for a multilink.
author Joseph Myers <jsm@polyomino.org.uk>
date Thu, 27 Sep 2018 11:33:01 +0000
parents c75defc1c2f0
children 9c3ec0a5c7fc
line wrap: on
line source

#! /usr/bin/env python
'''
Usage: %s <tracker home> <priority> <issue title>

Create a new issue in the given tracker. Input is taken from STDIN to
create the initial issue message (which may be empty). Issues will be
created as the current user (%s) if they exist as a Roundup
user, or "admin" otherwise.
'''

from __future__ import print_function
import sys, os, pwd

from roundup import instance, mailgw, date

# open the instance
username = pwd.getpwuid(os.getuid())[0]
if len(sys.argv) < 3:
    print("Error: Not enough arguments")
    print(__doc__.strip()%(sys.argv[0], username))
    sys.exit(1)
tracker_home = sys.argv[1]
issue_priority = sys.argv[2]
issue_title = ' '.join(sys.argv[3:])

# get the message, if any
message_text = sys.stdin.read().strip()

# open the tracker
tracker = instance.open(tracker_home)
db = tracker.open('admin')
db.tx_Source = "cli"
uid = db.user.lookup('admin')
try:
    # try to open the tracker as the current user
    uid = db.user.lookup(username)
    db.close()
    db = tracker.open(username)
except KeyError:
    pass

try:

    # handle the message
    messages = []
    if message_text:
        summary, x = mailgw.parseContent(message_text, 0, 0)
        msg = db.msg.create(content=message_text, summary=summary, author=uid,
            date=date.Date())
        messages = [msg]

    # now create the issue
    db.issue.create(title=issue_title, priority=issue_priority,
        messages=messages)

    db.commit()
finally:
    db.close()

# vim: set filetype=python ts=4 sw=4 et si

Roundup Issue Tracker: http://roundup-tracker.org/