Mercurial > p > roundup > code
view detectors/README.txt @ 5548:fea11d05110e
Avoid errors from selecting "no selection" on multilink (issue2550722).
As discussed in issue 2550722 there are various cases where selecting
"no selection" on a multilink can result in inappropriate errors from
Roundup:
* If selecting "no selection" produces a null edit (a value was set in
the multilink in an edit with an error, then removed again, along
with all other changes, in the next form submission), so the page is
rendered from the form contents including the "-<id>" value for "no
selection" for the multilink.
* If creating an item with a nonempty value for a multilink has an
error, and the resubmission changes that multilink to "no selection"
(and this in turn has subcases, according to whether the creation
then succeeds or fails on the resubmission, which need fixes in
different places in the Roundup code).
All of these cases have in common that it is expected and OK to have a
"-<id>" value for a submission for a multilink when <id> is not set in
that multilink in the database (because the original attempt to set
<id> in that multilink had an error), so the hyperdb.py logic to give
an error in that case is thus removed. In the subcase of the second
case where the resubmission with "no selection" has an error, the
templating code tries to produce a menu entry for the "-<id>"
multilink value, which also results in an error, hence the
templating.py change to ignore such values in the list for a
multilink.
| author | Joseph Myers <jsm@polyomino.org.uk> |
|---|---|
| date | Thu, 27 Sep 2018 11:33:01 +0000 |
| parents | ec06bd6ea156 |
| children | b2eb59ada444 |
line wrap: on
line source
This directory has some detector examples that you can use to get ideas on implementing your own detectors. These are provides on an as-is basis. When they were added, they worked for somebody and were considered a useful example. The roundup team will attempt to keep them up to date with major changes as they happen, but there are no guarantees that these will work out of the box. If you find them out of date and have patches to make them work against newer versions of roundup, please open an issue at: http://issues.roundup-tracker.org The current inventory is: creator_resolution.py - only allow the creator of the issue to resolve it emailauditor.py - Rename .eml files (from email multi-part bodies) to .mht so they can be downloaded/viewed in Internet Explorer. irker.py - communicate with irkerd to allow roundtup to send announcements to an IRC channel. newissuecopy.py - notify a team email address (hardcoded in the script) when a new issue arrives. newitemcopy.py - email the DISPATCHER address when new issues, users, keywords etc. are created. Kind of an expanded version of newissuecopy.
