Mercurial > p > roundup > code
view RELEASE.txt @ 5548:fea11d05110e
Avoid errors from selecting "no selection" on multilink (issue2550722).
As discussed in issue 2550722 there are various cases where selecting
"no selection" on a multilink can result in inappropriate errors from
Roundup:
* If selecting "no selection" produces a null edit (a value was set in
the multilink in an edit with an error, then removed again, along
with all other changes, in the next form submission), so the page is
rendered from the form contents including the "-<id>" value for "no
selection" for the multilink.
* If creating an item with a nonempty value for a multilink has an
error, and the resubmission changes that multilink to "no selection"
(and this in turn has subcases, according to whether the creation
then succeeds or fails on the resubmission, which need fixes in
different places in the Roundup code).
All of these cases have in common that it is expected and OK to have a
"-<id>" value for a submission for a multilink when <id> is not set in
that multilink in the database (because the original attempt to set
<id> in that multilink had an error), so the hyperdb.py logic to give
an error in that case is thus removed. In the subcase of the second
case where the resubmission with "no selection" has an error, the
templating code tries to produce a menu entry for the "-<id>"
multilink value, which also results in an error, hence the
templating.py change to ignore such values in the list for a
multilink.
| author | Joseph Myers <jsm@polyomino.org.uk> |
|---|---|
| date | Thu, 27 Sep 2018 11:33:01 +0000 |
| parents | 0036f4a7bf2a |
| children | bff95a7bcdbc |
line wrap: on
line source
Building Releases ================= Roundup is a pure Python application with no binary components. This file describes how to build a source release. To find out how to install Roundup, read the doc/installation.txt file. Roundup release checklist: 1. Regenerate locale/roundup.pot. See "Extracting Translatable Messages" in doc/developers.txt. This is best done some time in advance of the release to allow for translators to update their translations. 2. Run unit tests! They should pass successfully. "./run_tests.py" 3. Update version CHANGES.txt roundup/__init__.py website/www/index.txt website/www/conf.py (also update copyright) 3a. Update license end date in COPYING.txt 3b. Update doc/acknowledgements.txt (add section for release, churn contributers etc.). 4. Update documentation doc/announcement.txt doc/upgrading.txt 4a. cd to website/www and run 'make linkcheck'. See output in _tmp/linkcheck/output.txt fix broken references in docs verify redirects are correct 5. Update setup.py info is needed (contacts, classifiers, etc.), and check that metadata is valid and long descriptions is proper reST: python setup.py check --restructuredtext --metadata --strict 6. Clean out all *.orig, *.rej, .#* files from the source. 7. Remove previous build files python setup.py clean --all 8. Rebuild documentation in "share/doc/roundup/html" python setup.py build_doc 9. python setup.py sdist --manifest-only 10. Check the MANIFEST to make sure that any new files are included. (use hg status --rev <last release or tag>:tip to list changed added and removed files. Last release e.g. 1.5.1 where tip was what would become 1.6) If they are not, edit MANIFEST.in to include them. For format docs see http://docs.python.org/2/distutils/sourcedist.html#manifest-template 11. python setup.py sdist (if you find sdist a little verbose, add "--quiet" to the end of the command) 12. Unpack the new tarball created in dist/roundup-<version>.tar.gz file in /tmp then a) run_tests.py b) demo.py with all available Python versions. 13. Assuming all is well tag the release in the version-control system. a) hg tag 1.6.0 # use right version. Should create/commit a changeset b) hg push # update main repo c) hg sum # verify that the tag shows up 14. Upload source distributive to PyPI - requires you sign up for a pypi account and be added as a maintainer to roundup. Ask existing maintainer for access. python setup.py sdist upload --repository pypi --sign It should appear on http://pypi.python.org/pypi/roundup in no time. If you are using python older than 2.7.13 you need a .pypirc shown below. URL has changed. If using 2.7.13 or newer, you can remove the "--repository pypi" option. 15. Send doc/announcement.txt to python-announce@python.org and roundup-users@lists.sourceforge.net and roundup-devel@lists.sourceforge.net 16. Refresh website. website/README.txt http://www.roundup-tracker.org/ should state that the stable version is the one that you released. http://www.roundup-tracker.org/docs.html should also match the released version (or atleast the major 1.x release. So, those commands in a nice, cut'n'pasteable form:: find . -name '*.orig' -exec rm {} \; find . -name '*.rej' -exec rm {} \; find . -name '.#*' -exec rm {} \; python setup.py clean --all python setup.py check --restructuredtext --metadata --strict python setup.py build_doc python setup.py sdist --manifest-only python setup.py sdist --quiet python setup.py bdist_rpm # not required for pypi.org since 2017 -> python setup.py register python setup.py sdist upload --repository pypi --sign Note pypi no longer allows uploads of .exe installers such as produced by bdist_wininst. Removed directions for producing the binary distribution. If you get errors on the upload operation, you may need the following ~/.pypirc file as well ======== [distutils] index-servers = test pypi [pypi] repository: https://upload.pypi.org/legacy/ username: <your username on pypi.org here> password: <your password here> [test] repository: https://test.pypi.org/legacy/ username: <your username on test.pypi.org here> password: <your password here> ========
