Mercurial > p > roundup > code
view .hgtags @ 5548:fea11d05110e
Avoid errors from selecting "no selection" on multilink (issue2550722).
As discussed in issue 2550722 there are various cases where selecting
"no selection" on a multilink can result in inappropriate errors from
Roundup:
* If selecting "no selection" produces a null edit (a value was set in
the multilink in an edit with an error, then removed again, along
with all other changes, in the next form submission), so the page is
rendered from the form contents including the "-<id>" value for "no
selection" for the multilink.
* If creating an item with a nonempty value for a multilink has an
error, and the resubmission changes that multilink to "no selection"
(and this in turn has subcases, according to whether the creation
then succeeds or fails on the resubmission, which need fixes in
different places in the Roundup code).
All of these cases have in common that it is expected and OK to have a
"-<id>" value for a submission for a multilink when <id> is not set in
that multilink in the database (because the original attempt to set
<id> in that multilink had an error), so the hyperdb.py logic to give
an error in that case is thus removed. In the subcase of the second
case where the resubmission with "no selection" has an error, the
templating code tries to produce a menu entry for the "-<id>"
multilink value, which also results in an error, hence the
templating.py change to ignore such values in the list for a
multilink.
| author | Joseph Myers <jsm@polyomino.org.uk> |
|---|---|
| date | Thu, 27 Sep 2018 11:33:01 +0000 |
| parents | 8339410febf6 |
| children | 15c4fd250114 |
line wrap: on
line source
02ed2b7180e09b9bb029dc39de54cb380873ad73 0.5.8 05a65559d8737a131d47adbb0a14ebfde776adb2 1.4.13 05eb6a5966362613f68aecbd711001af4259eee3 1.4.15 08a17fc4dc01594bc2e9bd8f215f001cb04bfa1d 0.8.0-b1 0f79712460ecc3225f8a33765d9f2c44070b471e 1.3.2 0feb34b2de71fe80dfc003f4d6ebb402cc22db50 0.6.0b3 14e3bfec5e4a9c8ce98a6b8e90d7ebda05cc6a38 1.2.0 1555a73f64519f40e13ceaa4b397d431fa334c59 1.4.9 1e571b6be57ac1d958d124640d962e0c911c15c0 0.2.7 251382399e45a0635c930af5fc8bfcb37b609c6d 1.4.0 267e4ba89b542d3f22714444380026d16a059f6d 0.6.4 27700fe2d7c6f119f14f2f2f2ae0c4dc9f4a0ecd 1.0.1 2f2844231082fef22dac5c67a2f4070c68046bec 0.6.3 311375e4f2fe06e006deb2ffa6c7224106985f39 0.5.9 3b953be32cdc03504aae1caec8d84701697bb3d4 0.5.3 3dec28d96583ac7fb3ca4cbf47192051a527deb2 1.4.5 41dbd406a79ca68649b07e7679134128d38b0ec7 0.6.0a1 4299abf32e16df90e77b2409531ad1955cc251a2 1.3.3 431bf4e7d3d7a947ff5779a4fc3949015f506117 1.4.18 435cce827b40dc0b7ab3c7e0b40cc1bd63fc7a43 1.4.7 4a7caa50785bad510659f083031abd2eaa3a18bc 0.5.0 4cbbdcf449f660bc56462d65ff41a0daa2578f04 0.5.1 4ce71b5480a8f2ac6116c132eabf8999063c916b 1.4.11 4d1fa6e1fe8c67c4b0651282b36bd5db56597ac4 1.4.8 4d509f01d336746a1703614f29bd2555b0edf786 0.4.0 503d4c10f1f895e68531a10f9c029abe1de33a28 1.1.1 53e438d1ca19f40e47f5a97c8ee9d7361ba15005 1.4.17 54f98b078e44b0aa43475edca7b6db19587b3e50 0.8.4 553a27b25012660e7ad7dee407c9c0a47628135b 1.4.1 5a5cea3a432cc09042a15bac545baf780eca4d38 0.4.2 5b5596f7c8fbe3cb64c2610940d97a40e464000a 1.1.2 5cde43526788647b2ffd06936721a6c9f6dd2844 1.3.0 60dcb64d25d3b54a71e73458500b2296fb57e597 0.7.10 65090a899a192573cbddab04b3b31892e32f61c4 0.4.3 65bb0e974f200bd7bad47b308f70ffafa2691c85 0.7.3 677ee7ab8ac473a5c3a2d45aaf590771df1f7f57 0.3.0-pre3 68efe814ee3ef82f3167be442f23842ead737aef 0.8.5 6a96ad6436297c9dcc791fbede85c7cd64c05667 1.1.3 6b3a20ffb343cfdc8c30e19571dd147880bbd079 0.5.5 6d392197daa38daffb5915199fcdfc3d84076480 0.6.0b2 732d7aa833f7cf7f88cdb18e2a7a68055aeeed0f 0.8.2 762d65fefea5d8f7cfb2a64dcd1419ed9de87d1f 1.0.0 77f41a7e3e0314c416ca909e0ea9efbf8f740f36 0.7.2 7852c5bc75f6213dcb428d545acc70414dc33a44 0.7.0b3 7b14369be454616e6d25e87cd65a88f05f2f54e1 0.8.3 7b41d612539f5ebe8b3fb3c2f0335bc1ae3f7ac5 0.7.9 82a5757d01eb3f6f09c5d37bbecd96e8dcf307c1 0.3.0 8996815813df0d2b2beba50fb36cb5e297fa6aa1 0.6.0b4 8adaf5d169da82bc7a32c5d8e69a094f52ad82d9 0.4.4 904097de51c518341b440b905505bb7979b3e943 0.8.0-b2 905faf52a51f1d308e902ff6a9b13bb973407d1a 1.4.3 91c495476db35918e3a851fb7b69443a353eb31d 1.1.0 9560e94beeea9353960638ad089e3ccf30968186 0.6.2 9899d1da5240b830061a357ef66d764773c2eae1 0.7.1 9b34d8a79d79e79f47b03b85ae83cc93a4b7d7b6 0.5.0-b1 9b34f41507eda98ecea35c4290286919fed523c9 0.7.0 9c1da921cd3507e59ff2c798a07a220976a65cd2 0.6.0 a05d205e919cdd2e5c68cf4495c1a310f73b9b5e 0.5.7 a1f3314e1adf0832290f0d47062f601ab5d5e1fd 1.4.12 a467ee0f77dc80d5c297dc2f36c5c75ca608fd2a 0.6.8 a4b97ad133304dc939da99dd30121cd778bf79cf 0.5.4 a5b68d46bce8c6fbfa05743d5d2eb91eda8255d7 1.4.6 a6e3a9164814798c6e16545c65e0ec72807cf548 0.3.0-pre2 a6eff0dd2c9c28f8c1a9fa1387a2603e510e548a 1.3.1 a7a8b5434262ba7ed5142e18a5ca1d3ee3f4cf2b 0.7.4 b11142bb2aa2563780182634df1bf7d57c6b35b0 1.2.1 b1e81ad3fa6a23dcf36ee130502182edc56c128e 1.4.2 b654a33346a69c7939fa991cf56ce2e2d4d39a8c 0.7.8 b7404a96b58ac74bad85c1c1940f5e4a46b2e8ef 0.7.0b1 b939c3e78614a956baee64603533bb645b06f033 0.6.5 bddc72753d91b2f968778b58bef545bb957ac159 1.4.14 c7c25f2103b23f0c8aa9b12411ce288ebd42f5cb 0.7.12 ce6e868187de70b0b0ad5e788e27c784d3f90d6d 1.4.19 cec0f2a179c5b082b16c8206942dc9adfc0d2a0e 0.2.5 d1626710cff18c4404b5f1a24875730a7f85b74f 0.7.6 d1cda972f5d206247b9a834762aa30a5a248d8a4 0.8.6 d38ca22f7a2f3ed63f5e3604414648c353db6f7e 0.3.0-pre1 d39c37fd2940e3dc3c075248238b66e1c663cfe9 git d85cb1ad9bc906f3f795c839b4e02683d5477e85 0.6.1 dbef00943c6ebca17e5850b95230c16e8408a3bf 0.5.0-pr1 dea747e7d73dba66722fbcbde8deb3e557549331 0.7.0b2 e06ee3dd5ee82c929cb194023f64442b526194ae 0.4.1 e35e57ad90f0194011592b9c816e5bfb0affd838 1.4.16 e435d2b81547677bd41b5b9eac18c58e9da5c058 0.7.7 e481d576e8b4f9b4e37ff9e74272fe21f5289e13 0.6.9 eac669d738d11017e2547f8f6099dbca42da0004 0.5.0-b2 eb00a2fa0e0e06e76000bb1bddb0513eff4361e4 0.8.0 ecf6d8235061d1ad1c40fad70cd0f996b6c0d82d 0.4.2-pr1 ed404289b490567e88734a2dbc70fcabfef9ff02 0.5.6 f29a307ab3fe2eeacad43766fc05c45decc01c4f 1.0 f55b8be00de5f748b968046174cdaedaf8b6364c 0.2.0 f778acabf200eb7bd1384accdd61062fde66cb2d 0.7.5 fd4763c6efae2f9b371af15605f1dfc3a884d6d9 0.6.7 fe9d122f1bb16467c9cd794420be3cf2a58a3e43 0.6.11 ff3a8b7d1819765be3db6bbf174d7168fe5aecac 1.4.4 ffc6fa77e551fb74ae3ff6c71cc46ccfa58c5c1c 1.4.10 ffd14fa75beceaeae8f6c64bafae0abbb95a3529 0.6.10 59de7ad827e2f0070bd5ba49d4b27a00c69abd85 1.4.20 d6e9f95cc30e1e5e965f1b6cfede55afb6db57f3 1.4.21 f61bd780892e9f3078aa8b8c0b23fc370bcddae0 1.5.0 515ab1749b142caff31113425d1322b0ad360195 1.5.1 dc6cc2dbd70a15bceebb6665e1964a93d3e6829d 1.6.0