Mercurial > p > roundup > code
view website/www/contact.txt @ 6823:fe0091279f50
Refactor session db logging and key generation for sessions/otks
While I was working on the redis sessiondb stuff, I noticed that
log_wanrning, get_logger ... was duplicated. Also there was code to
generate a unique key for otks that was duplicated.
Changes:
creating new sessions_common.py and SessionsCommon class to provide
methods:
log_warning, log_info, log_debug, get_logger, getUniqueKey
getUniqueKey method is closer to the method used to make
session keys in client.py.
sessions_common.py now report when random_.py chooses a weak
random number generator. Removed same from rest.py.
get_logger reconciles all logging under
roundup.hyperdb.backends.<name of BasicDatabase class>
some backends used to log to root logger.
have BasicDatabase in other sessions_*.py modules inherit from
SessionCommon.
change logging to use log_* methods.
In addition:
remove unused imports reported by flake8 and other formatting
changes
modify actions.py, rest.py, templating.py to use getUniqueKey
method.
add tests for new methods
test_redis_session.py
swap out ModuleNotFoundError for ImportError to prevent crash in
python2 when redis is not present.
allow injection of username:password or just password into redis
connection URL. set pytest_redis_pw envirnment variable to password
or user:password when running test.
| author | John Rouillard <rouilj@ieee.org> |
|---|---|
| date | Sun, 07 Aug 2022 01:51:11 -0400 |
| parents | fefd8263ee4d |
| children | 6f5054751fb6 |
line wrap: on
line source
Contact ======= We maintain the following mailing lists: =================== ========================== roundup-users_ archives `[SourceForge]`__ roundup-devel_ archives `[SourceForge]`__ roundup-checkins_ archives `[SourceForge]`__ =================== ========================== These lists are moderated to protect them against spam. Please sign up if you intend to mail repeatedly. You may talk to Roundup developers directly via IRC irc://irc.oftc.net/roundup using IRC client or through WebChat_ interface. .. _roundup-users: https://sourceforge.net/projects/roundup/lists/roundup-users .. _roundup-devel: https://sourceforge.net/projects/roundup/lists/roundup-devel .. _roundup-checkins: https://sourceforge.net/projects/roundup/lists/roundup-checkins .. __: https://sourceforge.net/p/roundup/mailman/roundup-users/ .. __: https://sourceforge.net/p/roundup/mailman/roundup-devel/ .. __: https://sourceforge.net/p/roundup/mailman/roundup-checkins/ .. _WebChat: https://webchat.oftc.net/?randomnick=1&channels=roundup&prompt=1
