Mercurial > p > roundup > code
view website/issues/html/user.forgotten.html @ 6823:fe0091279f50
Refactor session db logging and key generation for sessions/otks
While I was working on the redis sessiondb stuff, I noticed that
log_wanrning, get_logger ... was duplicated. Also there was code to
generate a unique key for otks that was duplicated.
Changes:
creating new sessions_common.py and SessionsCommon class to provide
methods:
log_warning, log_info, log_debug, get_logger, getUniqueKey
getUniqueKey method is closer to the method used to make
session keys in client.py.
sessions_common.py now report when random_.py chooses a weak
random number generator. Removed same from rest.py.
get_logger reconciles all logging under
roundup.hyperdb.backends.<name of BasicDatabase class>
some backends used to log to root logger.
have BasicDatabase in other sessions_*.py modules inherit from
SessionCommon.
change logging to use log_* methods.
In addition:
remove unused imports reported by flake8 and other formatting
changes
modify actions.py, rest.py, templating.py to use getUniqueKey
method.
add tests for new methods
test_redis_session.py
swap out ModuleNotFoundError for ImportError to prevent crash in
python2 when redis is not present.
allow injection of username:password or just password into redis
connection URL. set pytest_redis_pw envirnment variable to password
or user:password when running test.
| author | John Rouillard <rouilj@ieee.org> |
|---|---|
| date | Sun, 07 Aug 2022 01:51:11 -0400 |
| parents | 53e9694788f5 |
| children |
line wrap: on
line source
<tal:block metal:use-macro="templates/page/macros/icing"> <title metal:fill-slot="head_title" i18n:translate="">Password reset request - <span i18n:name="tracker" tal:replace="config/TRACKER_NAME" /></title> <span metal:fill-slot="body_title" tal:omit-tag="python:1" i18n:translate="">Password reset request</span> <td class="content" metal:fill-slot="content"> <tal:askforinfo tal:condition="python:options['error_message'] or '@action' not in request.form"> <p i18n:translate="">You have two options if you have forgotten your password. If you know the email address you registered with, enter it below.</p> <p i18n:translate="">If your user was automatically created during import from the old sourceforge tracker, your e-mail address is <Sourceforge username>@users.sourceforge.net. The mail address associated with your account can be changed after login.</p> <form method="POST" onSubmit="return submit_once()" tal:attributes="action context/designator"> <table class="form"> <tr> <th i18n:translate="">Email Address:</th> <td><input name="address"></td> </tr> <tr> <td> </td> <td> <input type="hidden" name="@action" value="passrst"> <input type="hidden" name="@template" value="forgotten"> <input type="submit" value="Request password reset" i18n:attributes="value"> <input name="@csrf" type="hidden" tal:attributes="value python:utils.anti_csrf_nonce()"> </td> </tr> </table> <p i18n:translate="">Or, if you know your username, then enter it below.</p> <p i18n:translate="">If you have previously created or modified issue reports in the sourceforge issue tracker, you have an account here with the same username as your sourceforge username.</p> <table class="form"> <tr><th i18n:translate="">Username:</th> <td><input name="username"></td> </tr> <tr><td></td><td><input type="submit" value="Request password reset" i18n:attributes="value"></td></tr> </table> </form> <p i18n:translate="">A confirmation email will be sent to you - please follow the instructions within it to complete the reset process.</p> </tal:askforinfo> </td> g </tal:block>
