view website/issues/html/query.item.html @ 6823:fe0091279f50

Refactor session db logging and key generation for sessions/otks While I was working on the redis sessiondb stuff, I noticed that log_wanrning, get_logger ... was duplicated. Also there was code to generate a unique key for otks that was duplicated. Changes: creating new sessions_common.py and SessionsCommon class to provide methods: log_warning, log_info, log_debug, get_logger, getUniqueKey getUniqueKey method is closer to the method used to make session keys in client.py. sessions_common.py now report when random_.py chooses a weak random number generator. Removed same from rest.py. get_logger reconciles all logging under roundup.hyperdb.backends.<name of BasicDatabase class> some backends used to log to root logger. have BasicDatabase in other sessions_*.py modules inherit from SessionCommon. change logging to use log_* methods. In addition: remove unused imports reported by flake8 and other formatting changes modify actions.py, rest.py, templating.py to use getUniqueKey method. add tests for new methods test_redis_session.py swap out ModuleNotFoundError for ImportError to prevent crash in python2 when redis is not present. allow injection of username:password or just password into redis connection URL. set pytest_redis_pw envirnment variable to password or user:password when running test.
author John Rouillard <rouilj@ieee.org>
date Sun, 07 Aug 2022 01:51:11 -0400
parents 578b5294e888
children
line wrap: on
line source

<!-- query.item -->
<span tal:condition="context/is_view_ok" tal:replace="structure
      context/renderQueryForm" />
<tal:block tal:condition="not:context/is_view_ok">
  <tal:block metal:use-macro="templates/page/macros/icing">
    <title metal:fill-slot="head_title">You can not view query</title>
    <tal:block metal:fill-slot="body_title">
      You can not view query.
    </tal:block>
    <td class="content" metal:fill-slot="content">
      You are not allowed to view <span tal:content="context/_classname"/>
      with id <span tal:content="context/id"/>
    </td>
  </tal:block>
</tal:block>

Roundup Issue Tracker: http://roundup-tracker.org/