view website/issues/html/_generic.index.html @ 6823:fe0091279f50

Refactor session db logging and key generation for sessions/otks While I was working on the redis sessiondb stuff, I noticed that log_wanrning, get_logger ... was duplicated. Also there was code to generate a unique key for otks that was duplicated. Changes: creating new sessions_common.py and SessionsCommon class to provide methods: log_warning, log_info, log_debug, get_logger, getUniqueKey getUniqueKey method is closer to the method used to make session keys in client.py. sessions_common.py now report when random_.py chooses a weak random number generator. Removed same from rest.py. get_logger reconciles all logging under roundup.hyperdb.backends.<name of BasicDatabase class> some backends used to log to root logger. have BasicDatabase in other sessions_*.py modules inherit from SessionCommon. change logging to use log_* methods. In addition: remove unused imports reported by flake8 and other formatting changes modify actions.py, rest.py, templating.py to use getUniqueKey method. add tests for new methods test_redis_session.py swap out ModuleNotFoundError for ImportError to prevent crash in python2 when redis is not present. allow injection of username:password or just password into redis connection URL. set pytest_redis_pw envirnment variable to password or user:password when running test.
author John Rouillard <rouilj@ieee.org>
date Sun, 07 Aug 2022 01:51:11 -0400
parents 447a7647f237
children
line wrap: on
line source

<!-- dollarId: issue.index,v 1.2 2001/07/29 04:07:37 richard Exp dollar-->

<tal:block metal:use-macro="templates/page/macros/icing">
<title metal:fill-slot="head_title" i18n:translate=""
 ><span tal:replace="python:context._classname.capitalize()"
 i18n:name="class" /> editing - <span i18n:name="tracker"
 tal:replace="config/TRACKER_NAME" /></title>
<tal:block metal:fill-slot="body_title" i18n:translate=""
 ><span tal:replace="python:context._classname.capitalize()"
 i18n:name="class" /> editing</tal:block>

<td class="content" metal:fill-slot="content">

<span tal:condition="python:not (context.is_view_ok() or context.is_edit_ok()
 or request.user.hasRole('Anonymous'))"
 tal:omit-tag="python:1" i18n:translate=""
>You are not allowed to view this page.</span>

<span tal:condition="python:not (context.is_view_ok() or context.is_edit_ok())
 and request.user.hasRole('Anonymous')"
 tal:omit-tag="python:1" i18n:translate=""
>Please login with your username and password.</span>

<tal:block tal:condition="context/is_edit_ok">
<tal:block i18n:translate="">
<p class="form-help">
 You may edit the contents of the
 <span tal:replace="request/classname" i18n:name="classname"/>
 class using this form. Commas, newlines and double quotes (") must be
 handled delicately. You may include commas and newlines by enclosing the
 values in double-quotes ("). Double quotes themselves must be quoted by
 doubling ("").
</p>

<p class="form-help">
 Multilink properties have their multiple values colon (":") separated
 (... ,"one:two:three", ...)
</p>

<p class="form-help">
 Remove entries by deleting their line. Add new entries by appending
 them to the table - put an X in the id column. If you wish to restore a
 removed item and you know its id then just put that id in the id column.
</p>
</tal:block>
<form onSubmit="return submit_once()" method="POST"
      tal:attributes="action context/designator">
<textarea rows="15" style="width:90%" name="rows" tal:content="context/csv"></textarea>
<br>
<input name="@csrf" type="hidden"
       tal:attributes="value python:utils.anti_csrf_nonce()">
<input type="hidden" name="@action" value="editCSV">
<input type="submit" value="Edit Items" i18n:attributes="value">
</form>
</tal:block>

<table tal:condition="context/is_only_view_ok" width="100%" class="list">
 <tr>
  <th tal:repeat="property context/propnames" tal:content="property">&nbsp;</th>
 </tr>
 <tal:block repeat="item context/list">
 <tr tal:condition="item/is_view_ok"
     tal:attributes="class python:['normal', 'alt'][repeat['item'].index%6//3]">
  <td tal:repeat="property context/propnames"
   tal:content="python: item[property] or default"
  >&nbsp;</td>
 </tr>
 </tal:block>
</table>

</td>

</tal:block>

Roundup Issue Tracker: http://roundup-tracker.org/