Mercurial > p > roundup > code
view .hgignore @ 6823:fe0091279f50
Refactor session db logging and key generation for sessions/otks
While I was working on the redis sessiondb stuff, I noticed that
log_wanrning, get_logger ... was duplicated. Also there was code to
generate a unique key for otks that was duplicated.
Changes:
creating new sessions_common.py and SessionsCommon class to provide
methods:
log_warning, log_info, log_debug, get_logger, getUniqueKey
getUniqueKey method is closer to the method used to make
session keys in client.py.
sessions_common.py now report when random_.py chooses a weak
random number generator. Removed same from rest.py.
get_logger reconciles all logging under
roundup.hyperdb.backends.<name of BasicDatabase class>
some backends used to log to root logger.
have BasicDatabase in other sessions_*.py modules inherit from
SessionCommon.
change logging to use log_* methods.
In addition:
remove unused imports reported by flake8 and other formatting
changes
modify actions.py, rest.py, templating.py to use getUniqueKey
method.
add tests for new methods
test_redis_session.py
swap out ModuleNotFoundError for ImportError to prevent crash in
python2 when redis is not present.
allow injection of username:password or just password into redis
connection URL. set pytest_redis_pw envirnment variable to password
or user:password when running test.
| author | John Rouillard <rouilj@ieee.org> |
|---|---|
| date | Sun, 07 Aug 2022 01:51:11 -0400 |
| parents | 18445cd132c8 |
| children | b99e76e76496 |
line wrap: on
line source
syntax: glob *.orig *.rej *~ \#*\# .\#* *.swp *.tmp *.pyd *.pyc *.pyo build demo dist MANIFEST roundup.egg-info _test_* *.cover share/doc/roundup/html doc/FAQ.html doc/admin_guide.html doc/announcement.html doc/customizing.html doc/design.html doc/developers.html doc/features.html doc/glossary.html doc/implementation.html doc/index.html doc/installation.html doc/mysql.html doc/overview.html doc/postgresql.html doc/security.html doc/tracker_templates.html doc/upgrading.html doc/user_guide.html doc/whatsnew-0.7.html doc/whatsnew-0.8.html doc/xmlrpc.html locale/*.mo locale/*.bak locale/*.poedit website/www/_tmp/ website/www/COPYING.txt website/www/docs website/www/html/ .pytest_cache
