Mercurial > p > roundup > code
view website/issues/html/user.help.html @ 8185:e84d4585b16d
fix(web): issue2551356. Add etag header for not-modified (304) request.
When a 304 is returned to a conditional request for a static file,
print an ETag for the response.
ETag was always sent with a 200 response.
This also adds initial support for if-none-match conditional requests
for static files.
Changes:
Refactors the if-modified-since code out to a method.
It moves a file stat call from serve_static_file to _serve_file
so that an etag can be generated by both serve_static_file and
serve_file which call _serve_file.
Tests added. This does not test the codepath where serve_file pulls
content from the database rather than from a local file on disk.
Test mocking _serve_file changed to account for 5th argument to serve_file
BREAKING CHANGE:
function signature for client.py-Client::_serve_file() now has 5 not 4
parameters (added etag param). Since this is a "hidden" method I am
not too worried about it.
| author | John Rouillard <rouilj@ieee.org> |
|---|---|
| date | Tue, 10 Dec 2024 16:06:13 -0500 |
| parents | 28aa76443f58 |
| children |
line wrap: on
line source
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd"> <html tal:define="property request/form/property/value; qs request/env/QUERY_STRING; qs python:'&'.join([a for a in qs.split('&') if not a.startswith('@template=')]); form request/form/form/value; field request/form/property/value"> <head> <link rel="stylesheet" type="text/css" href="@@file/style.css" /> <meta http-equiv="Content-Type" tal:attributes="content string:text/html;; charset=${request/client/charset}" /> <tal:block tal:condition="python:'property' in request.form"> <title><tal:x i18n:translate=""><tal:x i18n:name="property" tal:content="property" i18n:translate="" /> help - <span i18n:name="tracker" tal:replace="config/TRACKER_NAME" /></tal:x></title> <script language="Javascript" type="text/javascript" tal:attributes="nonce request/client/client_nonce" tal:condition=false tal:content="string: // this is the name of the field in the original form that we're working on form = window.opener.document.${form}; field = '${field}';"> </script> <script src="@@file/help_controls.js" tal:attributes="nonce request/client/client_nonce" tal:condition=false type="text/javascript"><!-- //--></script> </tal:block> </head> <frameset rows="123,*,62"> <frame src="#" tal:attributes="src string:?@template=help-search&${qs}" name="search"> <!-- for search results: help-list --> <frame tal:attributes="src string:?@template=help-empty&${qs}" name="list"> <frame tal:attributes="src string:?@template=help-submit&${qs}" name="submit"> <!-- --> </frameset> <noframes> <body> <p i18n:translate=""> Your browser is not capable of using frames; you should be redirected immediately, or visit <a href="#" tal:attributes="href string:?${qs}&template=help-noframes" i18n:name="link">this link</a>. </p> </body> </noframes> </html>