Mercurial > p > roundup > code
view website/issues/html/user.forgotten.html @ 8185:e84d4585b16d
fix(web): issue2551356. Add etag header for not-modified (304) request.
When a 304 is returned to a conditional request for a static file,
print an ETag for the response.
ETag was always sent with a 200 response.
This also adds initial support for if-none-match conditional requests
for static files.
Changes:
Refactors the if-modified-since code out to a method.
It moves a file stat call from serve_static_file to _serve_file
so that an etag can be generated by both serve_static_file and
serve_file which call _serve_file.
Tests added. This does not test the codepath where serve_file pulls
content from the database rather than from a local file on disk.
Test mocking _serve_file changed to account for 5th argument to serve_file
BREAKING CHANGE:
function signature for client.py-Client::_serve_file() now has 5 not 4
parameters (added etag param). Since this is a "hidden" method I am
not too worried about it.
| author | John Rouillard <rouilj@ieee.org> |
|---|---|
| date | Tue, 10 Dec 2024 16:06:13 -0500 |
| parents | 53e9694788f5 |
| children |
line wrap: on
line source
<tal:block metal:use-macro="templates/page/macros/icing"> <title metal:fill-slot="head_title" i18n:translate="">Password reset request - <span i18n:name="tracker" tal:replace="config/TRACKER_NAME" /></title> <span metal:fill-slot="body_title" tal:omit-tag="python:1" i18n:translate="">Password reset request</span> <td class="content" metal:fill-slot="content"> <tal:askforinfo tal:condition="python:options['error_message'] or '@action' not in request.form"> <p i18n:translate="">You have two options if you have forgotten your password. If you know the email address you registered with, enter it below.</p> <p i18n:translate="">If your user was automatically created during import from the old sourceforge tracker, your e-mail address is <Sourceforge username>@users.sourceforge.net. The mail address associated with your account can be changed after login.</p> <form method="POST" onSubmit="return submit_once()" tal:attributes="action context/designator"> <table class="form"> <tr> <th i18n:translate="">Email Address:</th> <td><input name="address"></td> </tr> <tr> <td> </td> <td> <input type="hidden" name="@action" value="passrst"> <input type="hidden" name="@template" value="forgotten"> <input type="submit" value="Request password reset" i18n:attributes="value"> <input name="@csrf" type="hidden" tal:attributes="value python:utils.anti_csrf_nonce()"> </td> </tr> </table> <p i18n:translate="">Or, if you know your username, then enter it below.</p> <p i18n:translate="">If you have previously created or modified issue reports in the sourceforge issue tracker, you have an account here with the same username as your sourceforge username.</p> <table class="form"> <tr><th i18n:translate="">Username:</th> <td><input name="username"></td> </tr> <tr><td></td><td><input type="submit" value="Request password reset" i18n:attributes="value"></td></tr> </table> </form> <p i18n:translate="">A confirmation email will be sent to you - please follow the instructions within it to complete the reset process.</p> </tal:askforinfo> </td> g </tal:block>
