Mercurial > p > roundup > code
view website/issues/html/file.index.html @ 8185:e84d4585b16d
fix(web): issue2551356. Add etag header for not-modified (304) request.
When a 304 is returned to a conditional request for a static file,
print an ETag for the response.
ETag was always sent with a 200 response.
This also adds initial support for if-none-match conditional requests
for static files.
Changes:
Refactors the if-modified-since code out to a method.
It moves a file stat call from serve_static_file to _serve_file
so that an etag can be generated by both serve_static_file and
serve_file which call _serve_file.
Tests added. This does not test the codepath where serve_file pulls
content from the database rather than from a local file on disk.
Test mocking _serve_file changed to account for 5th argument to serve_file
BREAKING CHANGE:
function signature for client.py-Client::_serve_file() now has 5 not 4
parameters (added etag param). Since this is a "hidden" method I am
not too worried about it.
| author | John Rouillard <rouilj@ieee.org> |
|---|---|
| date | Tue, 10 Dec 2024 16:06:13 -0500 |
| parents | 447a7647f237 |
| children |
line wrap: on
line source
<tal:block metal:use-macro="templates/page/macros/icing"> <title metal:fill-slot="head_title" i18n:translate="" >List of files - <span tal:replace="config/TRACKER_NAME" i18n:name="tracker" /></title> <span metal:fill-slot="body_title" tal:omit-tag="python:1" i18n:translate="">List of files</span> <td class="content" metal:fill-slot="content"> <table class="otherinfo" tal:define="batch request/batch"> <tr><th style="padding-right: 10" i18n:translate="">Download</th> <th style="padding-right: 10" i18n:translate="">Description</th> <th style="padding-right: 10" i18n:translate="">Content Type</th> <th style="padding-right: 10" i18n:translate="">Uploaded By</th> <th style="padding-right: 10" i18n:translate="">Date</th> </tr> <tr tal:repeat="file batch" tal:attributes="class python:['normal', 'alt'][repeat['file'].index%6//3]"> <td> <a tal:attributes="href string:file${file/id}/${file/name}" tal:content="file/name">dld link</a> </td> <td tal:content="file/description">description</td> <td tal:content="file/type">content type</td> <td tal:content="file/creator">creator's name</td> <td tal:content="file/creation">creation date</td> </tr> <metal:block use-macro="templates/issue.index/macros/batch-footer" /> </table> </td> </tal:block>