Mercurial > p > roundup > code
view roundup/version_check.py @ 8185:e84d4585b16d
fix(web): issue2551356. Add etag header for not-modified (304) request.
When a 304 is returned to a conditional request for a static file,
print an ETag for the response.
ETag was always sent with a 200 response.
This also adds initial support for if-none-match conditional requests
for static files.
Changes:
Refactors the if-modified-since code out to a method.
It moves a file stat call from serve_static_file to _serve_file
so that an etag can be generated by both serve_static_file and
serve_file which call _serve_file.
Tests added. This does not test the codepath where serve_file pulls
content from the database rather than from a local file on disk.
Test mocking _serve_file changed to account for 5th argument to serve_file
BREAKING CHANGE:
function signature for client.py-Client::_serve_file() now has 5 not 4
parameters (added etag param). Since this is a "hidden" method I am
not too worried about it.
| author | John Rouillard <rouilj@ieee.org> |
|---|---|
| date | Tue, 10 Dec 2024 16:06:13 -0500 |
| parents | 9223ed67af05 |
| children | f72381d300a4 |
line wrap: on
line source
#!/usr/bin/env python # Roundup requires Python 2.7+ as mentioned in doc\installation.txt from __future__ import print_function import sys VERSION_NEEDED = (2, 7) if sys.version_info < VERSION_NEEDED: print("Content-Type: text/plain\n") print("Roundup requires Python %s.%s or newer." % VERSION_NEEDED) sys.exit(0)
