view website/issues/html/_generic.help-list.html @ 4880:ca692423e401

Different approach to fix XSS in issue2550817 Encapsulate the error/ok message append method as add_ok_message and add_error_message. The new approach escapes the messages when appending -- at a point in the code where we still know where the message comes from. Escaping is the default but can bei turned off. This also fixes issue2550836 where certain messages may contain links. Another advantage of the new fix is that users don't need to change installed trackers and are secure by default.
author Ralf Schlatterbeck <rsc@runtux.com>
date Mon, 31 Mar 2014 18:19:23 +0200
parents 6e3e4f24c753
children baa3e51d0f38
line wrap: on
line source

<!-- vim: sw=2 ts=8 et -->
<html tal:define="vok context/is_view_ok">
  <head>
    <title>Search result for user helper</title>
    <link rel="stylesheet" type="text/css" href="@@file/style.css" />
    <script language="Javascript" type="text/javascript"
        tal:content="structure string:<!--
        // this is the name of the field in the original form that we're working on
        form  = parent.opener.document.${request/form/form/value};
        field  = '${request/form/property/value}';
    //-->"></script>
    <script src="@@file/help_controls.js" type="text/javascript"></script>
<script type="text/javascript"><!--
var text_field = parent.submit.document.frm_help.text_preview;
//--></script>
  </head>
  <body>
    <pre tal:content="request/env/QUERY_STRING" tal:condition=false />

  <p tal:condition="not:vok" i18n:translate="">You are not
  allowed to view this page.</p>

  <tal:if condition="context/is_view_ok">
  <tal:def define="batch request/batch;">
  <form name=dummyform>
    <table width="100%"
      tal:define="template string:help-list"
      metal:use-macro="templates/help/macros/batch_navi"
      >
      <tr class="navigation">
       <th>
        <a href="#">&lt;&lt; previous</a>
       </th>
       <th i18n:translate="">1..25 out of 50
       </th>
       <th>
        <a href="#">next &gt;&gt;</a>
       </th>
      </tr>
     </table>

  <form name=dummyform>
  <table class="classhelp"
    tal:define="
       props python:request.form['properties'].value.split(',');
       legend templates/help/macros/legend;
    "><thead>
      <tr metal:use-macro="legend">
         <th>&nbsp;<b>x</b></th>
         <th tal:repeat="prop props" tal:content="prop" i18n:translate=""></th>
       </tr>
     </thead>
     <tfoot tal:condition=true>
       <tr metal:use-macro="legend" />
     </tfoot>
     <tbody>
       <tr tal:repeat="item batch">
         <tal:block tal:define="attr python:item[props[0]]" >
           <td>
             <input name="check"
             onclick="switch_val(text_field, this);" type="checkbox"
             tal:attributes="value attr; id string:id_$attr" />
             </td>
             <td tal:repeat="prop props">
                 <label class="classhelp-label"
                        tal:attributes="for string:id_$attr"
                        tal:content="structure python:item[prop]"></label>
             </td>
           </tal:block>
         </tr>
       </tbody>
     </table>
   </form>
     </tal:def>
     </tal:if>
     
     <pre tal:content=request tal:condition=false />
     <script type="text/javascript"><!--
       parent.submit.document.frm_help.cb_listpresent.checked=true;
       reviseList_framed(document.dummyform, text_field)
     //--></script>
  </body>
</html>

Roundup Issue Tracker: http://roundup-tracker.org/