Mercurial > p > roundup > code
view website/issues/html/home.about.html @ 6375:c4371ec7d1c0
Call verifyPassword even if user does not exist.
Address timing attack caused by not doing the password check if the
user doesn't exist. Can expose valid usernames. Really only useful for
a tracker that doesn't allow anonymous access to issues. Issues
usually show usernames as part of the message display.
| author | John Rouillard <rouilj@ieee.org> |
|---|---|
| date | Tue, 06 Apr 2021 22:51:55 -0400 |
| parents | 4155ed7f00f4 |
| children |
line wrap: on
line source
<!-- dollarId: issue.index,v 1.2 2001/07/29 04:07:37 richard Exp dollar--> <tal:block metal:use-macro="templates/page/macros/icing"> <title metal:fill-slot="head_title" i18n:translate="" > About this Tracker </title> <tal:block metal:fill-slot="body_title" i18n:translate=""> About this Tracker </tal:block> <div class="content" metal:fill-slot="content"> <span tal:condition="not:python:request.user.hasRole('Admin')" tal:omit-tag="python:1" i18n:translate=""> Please login with your username and password to find out about this tracker. </span> <div tal:condition="python:request.user.hasRole('Admin')" tal:omit-tag="python:1" i18n:translate=""> <div tal:replace="structure python:utils.AboutPage(db)"></div> </div> </div> </tal:block>