Mercurial > p > roundup > code
view website/issues/html/user.forgotten.html @ 6433:c1d3fbcdbfbd
issue2551142 - Import of retired node ... unique constraint failure.
Title: Import of retired node with username after active node fails
with unique constraint failure.
More fixes needed for mysql and postgresql.
mysql: add unique constraint for (keyvalue, __retired__) when
creating class in the database.
On schema change if class is changed, remove the unique
constraint too.
upgrade version of rdbms database from 5 to 6 to add constraint
to all version 5 databases that were created as version 5
and didn't get the unique constraint. Make no changes
on version 5 databases upgraded from version 4, the upgrade
process to 5 added the constraint. Make no changes
to other databases (sqlite, postgres) during upgrade from
version 5 to 6.
postgres: Handle the exception raised on unique constraint violation.
The exception invalidates the database connection so it
can't be used to recover from the exception.
Added two new database methods:
checkpoint_data - performs a db.commit under postgres
does nothing on other backends
restore_connection_on_error - does a db.rollback on
postgres, does nothing on other
backends
with the rollback() done on the connection I can use the
database connection to fixup the import that failed on the
unique constraint. This makes postgres slower but without the
commit after every imported object, the rollback will delete
all the entries done up to this point.
Trying to figure out how to make the caller do_import batch
and recover from this failure is beyond me.
Also dismissed having to process the export csv file before
importing. Pushing that onto a user just seems wrong. Also
since import/export isn't frequently done the lack of
surprise on having a failing import and reduced
load/frustration for the user seems worth it. Also the import
can be run in verbose mode where it prints out a row as it is
processed, so it may take a while, ut the user can get
feedback.
db_test-base.py: add test for upgrade from 5 to 6.
| author | John Rouillard <rouilj@ieee.org> |
|---|---|
| date | Thu, 10 Jun 2021 12:52:05 -0400 |
| parents | 53e9694788f5 |
| children |
line wrap: on
line source
<tal:block metal:use-macro="templates/page/macros/icing"> <title metal:fill-slot="head_title" i18n:translate="">Password reset request - <span i18n:name="tracker" tal:replace="config/TRACKER_NAME" /></title> <span metal:fill-slot="body_title" tal:omit-tag="python:1" i18n:translate="">Password reset request</span> <td class="content" metal:fill-slot="content"> <tal:askforinfo tal:condition="python:options['error_message'] or '@action' not in request.form"> <p i18n:translate="">You have two options if you have forgotten your password. If you know the email address you registered with, enter it below.</p> <p i18n:translate="">If your user was automatically created during import from the old sourceforge tracker, your e-mail address is <Sourceforge username>@users.sourceforge.net. The mail address associated with your account can be changed after login.</p> <form method="POST" onSubmit="return submit_once()" tal:attributes="action context/designator"> <table class="form"> <tr> <th i18n:translate="">Email Address:</th> <td><input name="address"></td> </tr> <tr> <td> </td> <td> <input type="hidden" name="@action" value="passrst"> <input type="hidden" name="@template" value="forgotten"> <input type="submit" value="Request password reset" i18n:attributes="value"> <input name="@csrf" type="hidden" tal:attributes="value python:utils.anti_csrf_nonce()"> </td> </tr> </table> <p i18n:translate="">Or, if you know your username, then enter it below.</p> <p i18n:translate="">If you have previously created or modified issue reports in the sourceforge issue tracker, you have an account here with the same username as your sourceforge username.</p> <table class="form"> <tr><th i18n:translate="">Username:</th> <td><input name="username"></td> </tr> <tr><td></td><td><input type="submit" value="Request password reset" i18n:attributes="value"></td></tr> </table> </form> <p i18n:translate="">A confirmation email will be sent to you - please follow the instructions within it to complete the reset process.</p> </tal:askforinfo> </td> g </tal:block>
