view website/issues/html/keyword.item.html @ 5525:bb7865241f8a

Make CSV import/export compatible across Python versions (also RDBMS journals) (issue 2550976, issue 2550975). The roundup-admin export and import commands are used for migrating between different database backends. It is desirable that they should be usable also for migrations between Python 2 and Python 3, and in some cases (e.g. with the anydbm backend) this may be required. To be usable for such migrations, the format of the generated CSV files needs to be stable, meaning the same as currently used with Python 2. The export process uses repr() to produce the fields in the CSV files and eval() to convert them back to Python data structures. repr() of strings with non-ASCII characters produces different results for Python 2 and Python 3. This patch adds repr_export and eval_import functions to roundup/anypy/strings.py which provide the required operations that are just repr() and eval() in Python 2, but are more complicated in Python 3 to use data representations compatible with Python 2. These functions are then used in the required places for export and import. repr() and eval() are also used in storing the dict of changed values in the journal for the RDBMS backends. It is similarly desirable that the database be compatible between Python 2 and Python 3, so that export and import do not need to be used for a migration between Python versions for non-anydbm back ends. Thus, this patch changes rdbms_common.py in the places involved in storing journals in the database, not just in those involved in import/export. Given this patch, import/export with non-ASCII characters appear based on some limited testing to work across Python versions, and an instance using the sqlite backend appears to be compatible between Python versions without needing import/export, *if* the sessions/otks databases (which use anydbm) are deleted when changing Python version.
author Joseph Myers <jsm@polyomino.org.uk>
date Sun, 02 Sep 2018 23:48:04 +0000
parents eff9c5435acc
children
line wrap: on
line source

<!-- dollarId: keyword.item,v 1.3 2002/05/22 00:32:34 richard Exp dollar-->
<tal:block metal:use-macro="templates/page/macros/icing">
<title metal:fill-slot="head_title" i18n:translate="">Keyword editing - <span
 i18n:name="tracker" tal:replace="config/TRACKER_NAME" /></title>
<span metal:fill-slot="body_title" tal:omit-tag="python:1"
 i18n:translate="">Keyword editing</span>
<td class="content" metal:fill-slot="content">

<table class="otherinfo" tal:define="keywords db/keyword/list"
       tal:condition="keywords">
 <tr><th colspan="4" class="header" i18n:translate="">Existing Keywords</th></tr>
 <tr tal:repeat="start python:range(0, len(keywords), 4)">
  <td width="25%" tal:define="batch python:utils.Batch(keywords, 4, start)"
      tal:repeat="keyword batch">
    <a tal:attributes="href string:keyword${keyword/id}"
       tal:content="keyword/name">keyword here</a>
  </td>
 </tr>
 <tr>
  <td colspan="4" style="border-top: 1px solid gray" i18n:translate="">
   To edit an existing keyword (for spelling or typing errors),
   click on its entry above.
  </td>
 </tr>
</table>

<p class="help" tal:condition="not:context/id" i18n:translate="">
 To create a new keyword, enter it below and click "Submit New Entry".
</p>

<form method="POST" onSubmit="return submit_once()"
      enctype="multipart/form-data"
      tal:attributes="action context/designator">

 <table class="form">
  <tr>
   <th i18n:translate="">Keyword</th>
   <td tal:content="structure python:context.name.field(size=60)">name</td>
  </tr>
  <tr>
    <th class="required" i18n:translate="">Description:</th>
    <td tal:content="structure python:context.description.field(size=60)">description</td>
  </tr>
  <tr>
   <td tal:condition="not:context/id">
     <tal:comment tal:replace="nothing">
       If we get here and do not have an id, we are creating a new
       keyword. It would be nice to provide some mechanism to
       determine the preferred state of the "Continue adding keywords"
       checkbox. By default I have it enabled.
     </tal:comment>
     <input type="checkbox" id="continue_new_keyword"
	    name="__redirect_to"
	    tal:attributes="value
			    string:${request/base}${request/env/PATH_INFO}?@template=item;
			    checked python:True" />
     <label for="continue_new_keyword" i18n:translate="">Continue adding keywords.</label>
   </td>
  </tr>

  <tr>
   <td>
    &nbsp;
    <input type="hidden" name="@required" value="name">
    <input type="hidden" name="@template" value="item">
   </td>
   <td colspan=3 tal:content="structure context/submit">
    submit button will go here
   </td>
  </tr>
 </table>
</form>
</td>

</tal:block>

Roundup Issue Tracker: http://roundup-tracker.org/