Mercurial > p > roundup > code
view scripts/dump_dbm_sessions_db.py @ 7752:b2dbab2b34bc
fix(refactor): multiple fixups using ruff linter; more testing.
Converting to using the ruff linter and its rulesets. Fixed a number
of issues.
admin.py:
sort imports
use immutable tuples as default value markers for parameters where a
None value is valid.
reduced some loops to list comprehensions for performance
used ternary to simplify some if statements
named some variables to make them less magic
(e.g. _default_savepoint_setting = 1000)
fixed some tests for argument counts < 2 becomes != 2 so 3 is an
error.
moved exception handlers outside of loops for performance where
exception handler will abort loop anyway.
renamed variables called 'id' or 'dir' as they shadow builtin
commands.
fix translations of form _("string %s" % value) -> _("string %s") %
value so translation will be looked up with the key before
substitution.
end dicts, tuples with a trailing comma to reduce missing comma
errors if modified
simplified sorted(list(self.setting.keys())) to
sorted(self.setting.keys()) as sorted consumes whole list.
in if conditions put compared variable on left and threshold condition
on right. (no yoda conditions)
multiple noqa: suppression
removed unneeded noqa as lint rulesets are a bit different
do_get - refactor output printing logic: Use fast return if not
special formatting is requested; use isinstance with a tuple
rather than two isinstance calls; cleaned up flow and removed
comments on algorithm as it can be easily read from the code.
do_filter, do_find - refactor output printing logic. Reduce
duplicate code.
do_find - renamed variable 'value' that was set inside a loop. The
loop index variable was also named 'value'.
do_pragma - added hint to use list subcommand if setting was not
found. Replaced condition 'type(x) is bool' with 'isinstance(x,
bool)' for various types.
test_admin.py
added testing for do_list
better test coverage for do_get includes: -S and -d for multilinks,
error case for -d with non-link.
better testing for do_find including all output modes
better testing for do_filter including all output modes
fixed expected output for do_pragma that now includes hint to use
pragma list if setting not found.
| author | John Rouillard <rouilj@ieee.org> |
|---|---|
| date | Fri, 01 Mar 2024 14:53:18 -0500 |
| parents | 1188bb423f92 |
| children | 9ba04f37896f |
line wrap: on
line source
#! /usr/bin/env python3 """Usage: dump_dbm_sessions_db.py [filename] Simple script to dump the otks and sessions dbm databases. Dumps sessions db in current directory if no argument is given. Dump format: key: <timestamp> data where <timestamp> is the human readable __timestamp decoded from the data object. Data object is dumped in json format. With pretty print key: <timestamp> { key: val, ... } if data is not a python object, print will be key: data or key: data if pretty printed. """ import argparse, dbm, json, marshal, os, sys from datetime import datetime def indent(text, amount, ch=" "): """ Found at: https://stackoverflow.com/a/8348914 """ padding = amount * ch return ''.join(padding+line for line in text.splitlines(True)) def print_marshal(k): d = marshal.loads(db[k]) try: t = datetime.fromtimestamp(d['__timestamp']) except (KeyError, TypeError): # TypeError raised if marshalled data is not a dict (list, tuple etc) t = "no_timestamp" if args.pretty: print("%s:\n %s\n%s"%(k, t, indent(json.dumps( d, sort_keys=True, indent=4), 4))) else: print("%s: %s %s"%(k, t, d)) def print_raw(k): if args.pretty: print("%s:\n %s"%(k, db[k])) else: print("%s: %s"%(k, db[k])) parser = argparse.ArgumentParser( description='Dump DBM files used by Roundup in storage order.') parser.add_argument('-k', '--key', action="append", help='dump the entry for a key, can be used multiple times.') parser.add_argument('-K', '--keysonly', action='store_true', help='print the database keys, sorted in byte order.') parser.add_argument('-p', '--pretty', action='store_true', help='pretty print the output rather than printing on one line.') parser.add_argument('file', nargs='?', help='file to be dumped ("sessions" if not provided)') args = parser.parse_args() if args.file: file = args.file else: file="sessions" try: db = dbm.open(file) except Exception as e: print("Unable to open database for %s: %s"%(file, e)) try: os.stat(file) print(" perhaps file is invalid or was created with a different version of Python?") except OSError: # the file does exist on disk. pass exit(1) if args.keysonly: for k in sorted(db.keys()): print("%s"%k) exit(0) if args.key: for k in args.key: try: print_marshal(k) except (ValueError): print_raw(k) exit(0) k = db.firstkey() while k is not None: try: print_marshal(k) except (ValueError): # ValueError marshal.loads failed print_raw(k) k = db.nextkey(k)
