Mercurial > p > roundup > code
view website/issues/html/user.help.html @ 8357:abf1297e7a94
bug(security): fix XSS exploit in devel and responsive templates
Replace all occurances of:
tal:content="structure context/MUMBLE/plain"
with
tal:content="context/MUMBLE/plain"
This seems to have been an old way to handle display of a field when
the user did not have edit rights. It does not occur in current (later
than 2009) classic tracker templates. But probably was unsed in
earlier classic templates since devel, reponsive and the roundup issue
tracker templates were based on classic.
Add CVE placeholder to security.txt and link to fix directions added
to upgrading.txt. Add note in announcement.txt and CHANGES.txt
Add a details element around the table of contents in the upgrading
guide. It was getting long.
Updated a missed XSS issue in the roundup tracker template. Live site
is already fixed.
XSS bug reported by 4bug of ChaMd5 Security Team H1 Group
| author | John Rouillard <rouilj@ieee.org> |
|---|---|
| date | Tue, 08 Jul 2025 13:38:08 -0400 |
| parents | 28aa76443f58 |
| children |
line wrap: on
line source
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd"> <html tal:define="property request/form/property/value; qs request/env/QUERY_STRING; qs python:'&'.join([a for a in qs.split('&') if not a.startswith('@template=')]); form request/form/form/value; field request/form/property/value"> <head> <link rel="stylesheet" type="text/css" href="@@file/style.css" /> <meta http-equiv="Content-Type" tal:attributes="content string:text/html;; charset=${request/client/charset}" /> <tal:block tal:condition="python:'property' in request.form"> <title><tal:x i18n:translate=""><tal:x i18n:name="property" tal:content="property" i18n:translate="" /> help - <span i18n:name="tracker" tal:replace="config/TRACKER_NAME" /></tal:x></title> <script language="Javascript" type="text/javascript" tal:attributes="nonce request/client/client_nonce" tal:condition=false tal:content="string: // this is the name of the field in the original form that we're working on form = window.opener.document.${form}; field = '${field}';"> </script> <script src="@@file/help_controls.js" tal:attributes="nonce request/client/client_nonce" tal:condition=false type="text/javascript"><!-- //--></script> </tal:block> </head> <frameset rows="123,*,62"> <frame src="#" tal:attributes="src string:?@template=help-search&${qs}" name="search"> <!-- for search results: help-list --> <frame tal:attributes="src string:?@template=help-empty&${qs}" name="list"> <frame tal:attributes="src string:?@template=help-submit&${qs}" name="submit"> <!-- --> </frameset> <noframes> <body> <p i18n:translate=""> Your browser is not capable of using frames; you should be redirected immediately, or visit <a href="#" tal:attributes="href string:?${qs}&template=help-noframes" i18n:name="link">this link</a>. </p> </body> </noframes> </html>