Mercurial > p > roundup > code
view website/issues/html/file.index.html @ 5222:9bf221cebef3
Make properties method return only properties the user can search.
See:
https://sourceforge.net/p/roundup/mailman/roundup-devel/thread/20170405002844.2004B80690%40vm71.cs.umb.edu/#msg35769250
[Roundup-devel] Bug in context/properties, lists properties user can't search.
The HTMLClass::properties() method returns a list of all
properties. This is used when creating sort on/group by filters on
index pages.
However somewhere in the code, a user needs search permission on the
property in order for it to be used for grouping or sorting.
This means the user can choose to sort/group an index page by a
property that they have no search permission for. As a result the
sort/group is ignored. This is confusing.
I have changed the properties method to only return properties the
user has View/Search permissions on. I also added a new cansearch
argument set by default to True. If set to False, all properties
regardless of Search permission are returned.
Doc updated to include the new default operation and mention the use
of cansearch argument.
| author | John Rouillard <rouilj@ieee.org> |
|---|---|
| date | Wed, 05 Apr 2017 21:38:32 -0400 |
| parents | baddbae588ad |
| children | 447a7647f237 |
line wrap: on
line source
<tal:block metal:use-macro="templates/page/macros/icing"> <title metal:fill-slot="head_title" i18n:translate="" >List of files - <span tal:replace="config/TRACKER_NAME" i18n:name="tracker" /></title> <span metal:fill-slot="body_title" tal:omit-tag="python:1" i18n:translate="">List of files</span> <td class="content" metal:fill-slot="content"> <table class="otherinfo" tal:define="batch request/batch"> <tr><th style="padding-right: 10" i18n:translate="">Download</th> <th style="padding-right: 10" i18n:translate="">Description</th> <th style="padding-right: 10" i18n:translate="">Content Type</th> <th style="padding-right: 10" i18n:translate="">Uploaded By</th> <th style="padding-right: 10" i18n:translate="">Date</th> </tr> <tr tal:repeat="file batch" tal:attributes="class python:['normal', 'alt'][repeat['file'].index%6/3]"> <td> <a tal:attributes="href string:file${file/id}/${file/name}" tal:content="file/name">dld link</a> </td> <td tal:content="file/description">description</td> <td tal:content="file/type">content type</td> <td tal:content="file/creator">creator's name</td> <td tal:content="file/creation">creation date</td> </tr> <metal:block use-macro="templates/issue.index/macros/batch-footer" /> </table> </td> </tal:block>