Mercurial > p > roundup > code
view website/issues/html/user.register.html @ 5257:928512faf565
- issue2550864: Potential information leakage via journal/history
Original code didn't fully implement the security checks.
Users with only Edit access on a property were not able to view the
journal entry for the property. This patch fixes that.
Also had additional info leakage: the target object of a link or
multilink must be viewable or editable in order for the journal entry
to be shown. Otherwise the existance of the target is exposed via the
journal while it is blocked from searches, direct access etc.
| author | John Rouillard <rouilj@ieee.org> |
|---|---|
| date | Sun, 27 Aug 2017 00:19:48 -0400 |
| parents | c2d0d3e9099d |
| children | f63a2b15e628 |
line wrap: on
line source
<tal:block metal:use-macro="templates/page/macros/icing"> <title metal:fill-slot="head_title" i18n:translate="">Registering with <span i18n:name="tracker" tal:replace="db/config/TRACKER_NAME" /></title> <span metal:fill-slot="body_title" tal:omit-tag="python:1" i18n:translate="">Registering with <span i18n:name="tracker" tal:replace="db/config/TRACKER_NAME" /></span> <td class="content" metal:fill-slot="content"> <p><span style="color:red; font-size:large;">NOTE</span>: If you have previously created or modified issue reports using the sourceforge issue tracker previously used for python bugs, your username on sourceforge already exists in this tracker. Use the <a href="user?@template=forgotten">Password recovery form</a> to get a password for your account.</p> <form method="POST" onSubmit="return submit_once()" enctype="multipart/form-data" tal:attributes="action context/designator"> <input type="hidden" name="opaque" tal:attributes="value python: utils.timestamp()" /> <table class="form"> <tr> <th i18n:translate="">Name</th> <td tal:content="structure context/realname/field">realname</td> </tr> <tr> <th class="required" i18n:translate="">Login Name</th> <td tal:content="structure context/username/field">username</td> </tr> <tr> <th class="required" i18n:translate="">Login Password</th> <td tal:content="structure context/password/field">password</td> </tr> <tr> <th class="required" i18n:translate="">Confirm Password</th> <td tal:content="structure context/password/confirm">password</td> </tr> <tr tal:condition="python:request.user.hasPermission('Web Roles')"> <th i18n:translate="">Roles</th> <td tal:condition="exists:item" tal:content="structure context/roles/field">roles</td> <td tal:condition="not:exists:item"> <input name="roles" tal:attributes="value db/config/NEW_WEB_USER_ROLES"> </td> </tr> <tr> <th i18n:translate="">Phone</th> <td tal:content="structure context/phone/field">phone</td> </tr> <tr> <th i18n:translate="">Organisation</th> <td tal:content="structure context/organisation/field">organisation</td> </tr> <tr> <th class="required" i18n:translate="">E-mail address</th> <td tal:content="structure context/address/field">address</td> </tr> <tr> <th i18n:translate="">Alternate E-mail addresses<br>One address per line</th> <td tal:content="structure context/alternate_addresses/multiline">alternate_addresses</td> </tr> <tr> <td> </td> <td> <input type="hidden" name="@template" value="register"> <input type="hidden" name="@required" value="username,password,address"> <input type="hidden" name="@action" value="register"> <input type="submit" name="submit" value="Register" i18n:attributes="value"> </td> </tr> </table> </form> <tal:block tal:condition="not:context/id" i18n:translate=""> <table class="form"> <tr> <td>Note: </td> <th class="required">highlighted</th> <td> fields are required.</td> </tr> </table> </tal:block> </td> </tal:block>
