view website/issues/html/keyword.index.html @ 5257:928512faf565

- issue2550864: Potential information leakage via journal/history Original code didn't fully implement the security checks. Users with only Edit access on a property were not able to view the journal entry for the property. This patch fixes that. Also had additional info leakage: the target object of a link or multilink must be viewable or editable in order for the journal entry to be shown. Otherwise the existance of the target is exposed via the journal while it is blocked from searches, direct access etc.
author John Rouillard <rouilj@ieee.org>
date Sun, 27 Aug 2017 00:19:48 -0400
parents c2d0d3e9099d
children 48658dcbac37
line wrap: on
line source

<tal:block metal:use-macro="templates/page/macros/icing">
<title metal:fill-slot="head_title" >
  <span tal:omit-tag="true" i18n:translate="" >List of keywords</span>
  <span tal:condition="request/dispname"
   tal:replace="python:' - %s '%request.dispname"
  /> - <span tal:replace="config/TRACKER_NAME" />
</title>
<span metal:fill-slot="body_title" tal:omit-tag="true">
  <span tal:omit-tag="true" i18n:translate="" >List of keywords</span>
  <span tal:condition="request/dispname"
   tal:replace="python:' - %s' % request.dispname" />
</span>
<tal:block metal:fill-slot="content">

<p tal:condition="python:not (context.is_view_ok()
 or request.user.hasRole('Anonymous'))" i18n:translate="">
 You are not allowed to view this page.</p>

<p tal:condition="python:not context.is_view_ok()
 and request.user.hasRole('Anonymous')" i18n:translate="">
 Please login with your username and password.</p>

<table width="100%" tal:condition="context/is_view_ok" class="list">
<tr>
 <th i18n:translate="">Keyword</th>
 <th i18n:translate="">Description</th>
</tr>

<tal:block repeat="keyword context/list">
<tr tal:attributes="class python:['normal', 'alt'][repeat['keyword'].index%6/3]">
 <td>
  <a tal:attributes="href string:keyword${keyword/id}"
     tal:content="keyword/name">keyword name</a>
 </td>
 <td tal:content="python:keyword.description.plain() or
     default">&nbsp;</td>
</tr>
</tal:block>

<tr tal:condition="context/is_edit_ok">
   <td colspan="2"><a href="keyword?@template=item">New Keyword</a></td>
</tr>
</table>

</tal:block>
</tal:block>

Roundup Issue Tracker: http://roundup-tracker.org/