view website/issues/html/_generic.help-list.html @ 5257:928512faf565

- issue2550864: Potential information leakage via journal/history Original code didn't fully implement the security checks. Users with only Edit access on a property were not able to view the journal entry for the property. This patch fixes that. Also had additional info leakage: the target object of a link or multilink must be viewable or editable in order for the journal entry to be shown. Otherwise the existance of the target is exposed via the journal while it is blocked from searches, direct access etc.
author John Rouillard <rouilj@ieee.org>
date Sun, 27 Aug 2017 00:19:48 -0400
parents 6e3e4f24c753
children baa3e51d0f38
line wrap: on
line source

<!-- vim: sw=2 ts=8 et -->
<html tal:define="vok context/is_view_ok">
  <head>
    <title>Search result for user helper</title>
    <link rel="stylesheet" type="text/css" href="@@file/style.css" />
    <script language="Javascript" type="text/javascript"
        tal:content="structure string:<!--
        // this is the name of the field in the original form that we're working on
        form  = parent.opener.document.${request/form/form/value};
        field  = '${request/form/property/value}';
    //-->"></script>
    <script src="@@file/help_controls.js" type="text/javascript"></script>
<script type="text/javascript"><!--
var text_field = parent.submit.document.frm_help.text_preview;
//--></script>
  </head>
  <body>
    <pre tal:content="request/env/QUERY_STRING" tal:condition=false />

  <p tal:condition="not:vok" i18n:translate="">You are not
  allowed to view this page.</p>

  <tal:if condition="context/is_view_ok">
  <tal:def define="batch request/batch;">
  <form name=dummyform>
    <table width="100%"
      tal:define="template string:help-list"
      metal:use-macro="templates/help/macros/batch_navi"
      >
      <tr class="navigation">
       <th>
        <a href="#">&lt;&lt; previous</a>
       </th>
       <th i18n:translate="">1..25 out of 50
       </th>
       <th>
        <a href="#">next &gt;&gt;</a>
       </th>
      </tr>
     </table>

  <form name=dummyform>
  <table class="classhelp"
    tal:define="
       props python:request.form['properties'].value.split(',');
       legend templates/help/macros/legend;
    "><thead>
      <tr metal:use-macro="legend">
         <th>&nbsp;<b>x</b></th>
         <th tal:repeat="prop props" tal:content="prop" i18n:translate=""></th>
       </tr>
     </thead>
     <tfoot tal:condition=true>
       <tr metal:use-macro="legend" />
     </tfoot>
     <tbody>
       <tr tal:repeat="item batch">
         <tal:block tal:define="attr python:item[props[0]]" >
           <td>
             <input name="check"
             onclick="switch_val(text_field, this);" type="checkbox"
             tal:attributes="value attr; id string:id_$attr" />
             </td>
             <td tal:repeat="prop props">
                 <label class="classhelp-label"
                        tal:attributes="for string:id_$attr"
                        tal:content="structure python:item[prop]"></label>
             </td>
           </tal:block>
         </tr>
       </tbody>
     </table>
   </form>
     </tal:def>
     </tal:if>
     
     <pre tal:content=request tal:condition=false />
     <script type="text/javascript"><!--
       parent.submit.document.frm_help.cb_listpresent.checked=true;
       reviseList_framed(document.dummyform, text_field)
     //--></script>
  </body>
</html>

Roundup Issue Tracker: http://roundup-tracker.org/