Mercurial > p > roundup > code
view website/issues/detectors/patches.py @ 5133:85eee1f236b2
I had an incorrect fix for issue2550601. Changed schema to define
class patches not patch.
Changed commented out patches section in bug.item.html to
use patches-1 an not patch-1 as a result of schema changes.
The show open Milestones link had a leak of the @group
value. If you clicked on show open tasks or show open bugs
they group by priority.
The url being formed for show open milestones was inheriting the @group
if you were on an index page for bugs or milestones. Explicit set the
@group to status (which a milestone does have) prevents the
@group=priority from being applied to a milestone index page which
results in a red error banner stating priority is an invalid param for
milestones.
./demo.py -t devel now runs without obvious breakage.
| author | John Rouillard <rouilj@ieee.org> |
|---|---|
| date | Mon, 04 Jul 2016 18:19:51 -0400 |
| parents | c2d0d3e9099d |
| children | 0942fe89e82e |
line wrap: on
line source
# Auditor for patch files # Patches should be declared as text/plain (also .py files), # independent of what the browser says, and # the "patch" keyword should get set automatically. import posixpath patchtypes = ('.diff', '.patch') sourcetypes = ('.diff', '.patch', '.py') def ispatch(file, types): return posixpath.splitext(file)[1] in types def patches_text_plain(db, cl, nodeid, newvalues): if ispatch(newvalues['name'], sourcetypes): newvalues['type'] = 'text/plain' def patches_keyword(db, cl, nodeid, newvalues): # Check whether there are any new files newfiles = set(newvalues.get('files',())) if nodeid: newfiles -= set(db.issue.get(nodeid, 'files')) # Check whether any of these is a patch newpatch = False for fileid in newfiles: if ispatch(db.file.get(fileid, 'name'), patchtypes): newpatch = True break if newpatch: # Add the patch keyword if its not already there patchid = db.keyword.lookup("patch") oldkeywords = [] if nodeid: oldkeywords = db.issue.get(nodeid, 'keywords') if patchid in oldkeywords: # This is already marked as a patch return if not newvalues.has_key('keywords'): newvalues['keywords'] = oldkeywords newvalues['keywords'].append(patchid) def init(db): db.file.audit('create', patches_text_plain) db.issue.audit('create', patches_keyword) db.issue.audit('set', patches_keyword)
