Mercurial > p > roundup > code
view roundup/actions.py @ 5133:85eee1f236b2
I had an incorrect fix for issue2550601. Changed schema to define
class patches not patch.
Changed commented out patches section in bug.item.html to
use patches-1 an not patch-1 as a result of schema changes.
The show open Milestones link had a leak of the @group
value. If you clicked on show open tasks or show open bugs
they group by priority.
The url being formed for show open milestones was inheriting the @group
if you were on an index page for bugs or milestones. Explicit set the
@group to status (which a milestone does have) prevents the
@group=priority from being applied to a milestone index page which
results in a red error banner stating priority is an invalid param for
milestones.
./demo.py -t devel now runs without obvious breakage.
| author | John Rouillard <rouilj@ieee.org> |
|---|---|
| date | Mon, 04 Jul 2016 18:19:51 -0400 |
| parents | a7541077cf12 |
| children | ed02a1e0aa5d |
line wrap: on
line source
# # Copyright (C) 2009 Stefan Seefeld # All rights reserved. # For license terms see the file COPYING.txt. # from roundup.exceptions import Unauthorised from roundup import hyperdb from roundup.i18n import _ class Action: def __init__(self, db, translator): self.db = db self.translator = translator def handle(self, *args): """Action handler procedure""" raise NotImplementedError def execute(self, *args): """Execute the action specified by this object.""" self.permission(*args) return self.handle(*args) def permission(self, *args): """Check whether the user has permission to execute this action. If not, raise Unauthorised.""" pass def gettext(self, msgid): """Return the localized translation of msgid""" return self.translator.gettext(msgid) _ = gettext class Retire(Action): def handle(self, designator): classname, itemid = hyperdb.splitDesignator(designator) # make sure we don't try to retire admin or anonymous if (classname == 'user' and self.db.user.get(itemid, 'username') in ('admin', 'anonymous')): raise ValueError(self._( 'You may not retire the admin or anonymous user')) # do the retire self.db.getclass(classname).retire(itemid) self.db.commit() def permission(self, designator): classname, itemid = hyperdb.splitDesignator(designator) if not self.db.security.hasPermission('Edit', self.db.getuid(), classname=classname, itemid=itemid): raise Unauthorised(self._('You do not have permission to ' 'retire the %(classname)s class.')%classname)
